Quantcast

[ANN] Please use Gerrit from now on for Patch Review

classic Classic list List threaded Threaded
3 messages Options
Bjoern Michaelsen Bjoern Michaelsen
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[ANN] Please use Gerrit from now on for Patch Review


Hi all,

with:

 http://sweetshark.livejournal.com/13298.html

gerrit is documented and ready to go. Please use it for code review as much as
possible now as it simplifies things a lot over manual patch fiddling on
mailing lists. I will update the EasyHacks to point to gerrit instead in the
next days.
The last remaining step will be making the repo at gerrit the reference (and
the one at freedesktop a read-only mirror). I assume that to be prepared and
done until mid-July(*).
>From that point on, we will have a lot of opportunity to improve our tinderbox
testing and reporting, making life easier and better for everyone working on
the codebase.

Best,

Bjoern

(*) Along with the "other" repos.

--
Unsubscribe instructions: E-mail to [hidden email]
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/projects/
All messages sent to this list will be publicly archived and cannot be deleted

Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [ANN] Please use Gerrit from now on for Patch Review

Bjoern Michaelsen píše v Po 18. 06. 2012 v 12:09 +0200:
> Hi all,
>
> with:
>
>  http://sweetshark.livejournal.com/13298.html
>
> gerrit is documented and ready to go.

Ah, there are several strange and long commands.

Also I miss the cooperation with the mailing list. I remember that the
main request was that mailing list will stay the main communication
point between developers. All patches that need review must be mentioned
there.

It means that gerrit should be able to detect patches for review on the
mailing list, integrate them, and make them ready for review.

My expectation would be that it sends a replay to the mailing list with
a link to diff, link to build results and commands to approve it.

Similar mail should be send for patches that were directly pushed into
gerrit for review. Of course, it must not send mail for every single
patch but just for patches where the developer explicitly asks for
review, so the numbers of mails on the mailing list stays the same.

> Please use it for code review as much as possible now as it simplifies
>  things a lot over manual patch fiddling on mailing lists. I will
>  update the EasyHacks to point to gerrit instead in the next days.

IMHO, we first need to conclude that gerrit is in usable state.


> The last remaining step will be making the repo at gerrit the reference (and
> the one at freedesktop a read-only mirror). I assume that to be prepared and
> done until mid-July(*).

Same here.

Best Regards,
Petr

PS: To make it clear. I am neutral about gerrit. I see some advantages
and also some risks. In each case, we must make Caolan, Kendy, Michael,
Stefan, Eike, Miklos, and all other very active patch reviewers happy
with it. I am excited when I look at the current mailing list and see so
many patches reviewed a pushed within one or two days. It helps to make
contributors active. It helps me a lot to do the tag in time. We must
not break this flow!


--
Unsubscribe instructions: E-mail to [hidden email]
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/projects/
All messages sent to this list will be publicly archived and cannot be deleted
Lionel Elie Mamane Lionel Elie Mamane
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [ANN] Please use Gerrit from now on for Patch Review

In reply to this post by Bjoern Michaelsen
On Thu, Jun 21, 2012 at 07:08:46PM +0200, Pierre-André Jacquod wrote:

> Just to say, I basically just really do not like the fact of having
> to use openId, would prefer to have an account at fd.o. I did it
> really for the LibO, a kind of forced to. And NO, I do NOT have any
> google, flickr, facebook or other account. Do not trust them enough
> to put my data there, so to use them as authentication.... But no
> choice (!) I kind of understood. [+1 for / to Lionel thread]

Would you be made much happier if there would be a TDF or FDO OpenID
provider, which you would use only to authenticate to TDF (or FDO)
services?

--
Lionel

--
Unsubscribe instructions: E-mail to [hidden email]
Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/
Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette
List archive: http://listarchives.libreoffice.org/global/projects/
All messages sent to this list will be publicly archived and cannot be deleted

Loading...