[BUILD] consistent test failures under windows

Hello

I pasted the end of the build log to http://pastebin.com/fg6aNutr. This  
was a clean complete make

Autogen.lastrun is:
--with-max-jobs=6
--with-num-cpus=3
--disable-directx
--disable-binfilter
--without-junit
--disable-build-mozilla
--with-mozilla-build=/cygdrive/c/data/mozilla-build
--with-ant-home=/ant
--disable-odk
--with-windows-sdk-home=/cygdrive/C/Program Files/Microsoft  
SDKs/Windows/v7.1
--disable-activex
--disable-atl
--with-dotnet-framework-home=/cygdrive/C/Program Files/Microsoft  
SDKs/Windows/v6.0A

OS: Win 7 x64

HEAD was:
mm@FAUCON /cygdrive/h/src/libo
$ git log -1
commit c24c5101f573e6a25ff06e8399c53dbc2510a7da
Author: Rene Engelhard <[hidden email]>
Date:   Fri Jun 8 21:04:41 2012 +0200

     fix build verbosity

     Change-Id: I55d944652de2c716fd1548e5ee64a10c2fb645e0


Errors are 2 failures in tests:

file:///H:/src/libo/sd/qa/unit/data/ppt/pass/CVE-2006-3655-1.ppt,H:/src/libo/unotest/source/cpp/filters-test.cxx(123)  
: error : Assertion
Test name: SdFiltersTest::testCVEs
assertion failed
- Expression: osl::FileBase::E_None == osl::File::remove(sTmpFile)

Failures !!!
Run: 2   Failure total: 1   Failures: 1   Errors: 0

  AND

File tested,Test Result,Execution Time (ms)
file:///H:/src/libo/sw/qa/core/data/xml/fail/CVE-2006-3117-1.sxw,Fail,140
File tested,Test Result,Execution Time (ms)
file:///H:/src/libo/sw/qa/core/data/ww8/pass/CVE-2003-0820-1.doc,H:/src/libo/unotest/source/cpp/filters-test.cxx(123)  
: error : Assertion
Test name: SwFiltersTest::testCVEs
assertion failed
- Expression: osl::FileBase::E_None == osl::File::remove(sTmpFile)

Failures !!!
Run: 1   Failure total: 1   Failures: 1   Errors: 0


I don't know if it is windows specific or commit specific. I have this  
errors since last monday after a fresh ./g pull.

Does someone reproduce under Win/Linux ?
Or what should I do to be sure the test is really broken and not my build ?

regards

--
Mat M
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hello Mat,

On Sat, Jun 9, 2012 at 7:29 PM, Mat M <[hidden email]> wrote:
> Or what should I do to be sure the test is really broken and not my build ?

I think you should disable your antivirus during the build. It
captures CVE files as a threat, and delete / quarantine them.

Best Regards,
--
Korrawit Pruegsanusak
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Mat,

On Sat, 2012-06-09 at 14:29 +0200, Mat M wrote:
> I pasted the end of the build log to http://pastebin.com/fg6aNutr. This  
> was a clean complete make

        Thanks :-)

> Autogen.lastrun is:
> --with-max-jobs=6

        Parameters look sensible.

        This -looks- like the failure I was getting.

        Can you move away your 'sd' directory, and assuming you have no changes
(otherwise save them) do a:

        git reset --hard

        And then re-run in sd. If your tests then pass (as I suspect they
will), it'd be -great- to have a:

        diff -ur sd.orig sd

        I suspect this is some poisoning of the test directory / data itself.
Actually the 'git status' output might show us that too :-)

> Does someone reproduce under Win/Linux ?
> Or what should I do to be sure the test is really broken and not my build ?

        I had something similar, but by the time I'd worked out that the above
might fix it - I had deleted the contents of the directory.

        Sorry for the trouble; It is possible that Korrawit's advice is
correct, although we now encrypt the CVE documents to avoid triggering
virus checkers - though you might have a clever one ... ;-)

        HTH !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hello


Le Sun, 10 Jun 2012 12:44:42 +0200, Korrawit Pruegsanusak  
<[hidden email]> a écrit:

For sake of completeness, I tried, found it worked. I so decided to limit  
AV to exclude filescan from libo dirs (so AV filescan is not always  
disabled), but did not worked.
I eventually found that files are copied into the tmp folder of cygwin  
before being used by tests, so c:\cygwin\tmp is the path to exclude, not  
the libo sources one.

Regards
--
Mat M
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

Zitat von Mat M <[hidden email]>:

it only works if you do have admin rights.
Think about enterprise where you do not have it.
In that case you will end up manually commented all CVE
cpp units calls in the tree (and there are a lot).

Actually I'm missing the build option:
--without-ccpunit (or at least --without-cve-unit)

Unit tests are really important and we need more of them.
In some circumstances however (tracking down critical problems on some strange platform) all you want is to get debug build done and not to mess around with ... antivirus settings!

Unfortunatelly current integration of cpp units in LO build
infrastructure is broken. To see why try to activate the production
option --without-xmlsec on linux ... and you will not be able to build at all.

And yes I provided a patch for that (you can find it on ML) and it was rejected with (a bad) joke justification: you *should* not use *this* option on linux.

Another option would be to introduce some means to activate only specific cpp units:
--enable-cppunit="sw"
like lately introduced per lib activation of debug symbols.

I am going to provide a patch for this option:
--without-cppunit (note we have already --without-junit).
It more or less one line change ... so next time you would have a choice ;-)

Regards
David
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hello

Le Tue, 03 Jul 2012 09:42:46 +0200, David Ostrovsky <[hidden email]> a  
écrit:
I'm at home, so no issue with that, right.
About AV, --without-cve-unit is enough, but having a way to bypass unit  
testing could be practical for some specific cases.

regards
--
Mat M
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hello David, Mat,

>
> it only works if you do have admin rights.
> Think about enterprise where you do not have it.
> In that case you will end up manually commented all CVE
> cpp units calls in the tree (and there are a lot).

I doubt that you're allowed to build LibO in such an environment.

--without-xmlsec is not an option for Linux builds. You may call it a
bad joke but it was never intended for this purpose. This is not
broken, this has been added by design to make sure that we will never
again get into the siutation where we can't open any of our password
protected files.

>
> And yes I provided a patch for that (you can find it on ML) and it was rejected with (a bad) joke justification: you *should* not use *this* option on linux.
>
> Another option would be to introduce some means to activate only specific cpp units:
> --enable-cppunit="sw"
> like lately introduced per lib activation of debug symbols.

I'm strongly against this idea. Everyone should ALWAYS execute all
tests and not only the tests someone thinks are useful. You can see at
the subsequenttests what happens to tests that are optional.

>
> I am going to provide a patch for this option:
> --without-cppunit (note we have already --without-junit).
> It more or less one line change ... so next time you would have a choice ;-)
>

Please save your time and work on something more useful. There are
ways to prevent the execution of the unit tests during the build but
they are not widespread for good reasons. We learned in the past that
we need to make it as difficult as possible to build without executing
the unit tests. All our tests should normally execute fine on all
major platforms and if not that is a serious bug and we need to fix it
as fast as possible. IMHO adding a simple documented way to disable
the unit test will make many more developers disable them and in the
end result in more broken tests and undiscovered bugs.

Regards,
Markus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Wed, 2012-07-04 at 01:32 +0200, Mat M wrote:
> About AV, --without-cve-unit is enough, but having a way to bypass unit  
> testing could be practical for some specific cases.

        I tend to agree that a --without-cve-unit option make some sense, and
is vastly preferable (as Markus points out) to making it easy to disable
the cppunit tests generally :-)

        A -really-smart-[1] anti-virus checker will notice that we have
de-crypted the CVE documents in memory and will kill our unit tests in
response; so the encryption on disk would only help us get them
downloaded I suspect.

        Thanks :-)

                Michael.

[1] - you know the ones that bring your machine nearly to it's knees.
--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice