Document Foundation Mail Archive › LibreOffice › Dev

Dialogs - Why so Inconsistent

Classic

List

Threaded

2 messages Options

jmadero

Dialogs - Why so Inconsistent

Hi All,

I'm browsing through the code for a few dialogs and I'm seeing a ridiculous amount of inconsistencies, the programming styles are just so different that it makes it hard to efficiently work on them. A couple that can be seen:

optgdlg (cui)

optload (sw)

optdlg (sw)

optjava (cui)

Even simple things like position are handled different, some define columns as COL and then use those in the src file while others directly put in positions (X,Y).

My questions are:

1. Is this okay?

2. Is this efficient?

3. Out of the dialogs, which has the "best methodology" and then maybe I'l slowly start cleaning the others to be similar to the "best" one

Best Regards,

Joel

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Miklos Vajna-2

Re: Dialogs - Why so Inconsistent

On Wed, Sep 19, 2012 at 10:10:04AM -0700, Joel Madero <[hidden email]> wrote:

> Even simple things like position are handled different, some define columns
> as COL and then use those in the src file while others directly put in
> positions (X,Y).
>
> My questions are:
>
> 1. Is this okay?
> 2. Is this efficient?
> 3. Out of the dialogs, which has the "best methodology" and then maybe I'l
> slowly start cleaning the others to be similar to the "best" one

The best is what Caolán does in the feature/cmclayouttrans branch to get
rid of the src format for dialog definitions. If you want to help, I'm
sure you can join the effort there. :-)
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice