Quantcast

Easy Hack solved: Remove mid-file emacs modelines

classic Classic list List threaded Threaded
11 messages Options
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Easy Hack solved: Remove mid-file emacs modelines

4 patches following this patch for filters, libs-core, libs-gui, writer
repositories killing all mid-file emacs modelines.

If these are applied, I'll delete the corresponding easy hack on the
wiki.

Thanks.
Sebastian

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (203 bytes) Download Attachment
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PATCH] filter: Remove emacs modelines in the middle of the file


Signed-off-by: Sebastian Spaeth <[hidden email]>
---
 filter/source/msfilter/msdffimp.cxx  |    2 +-
 filter/source/msfilter/msocximex.cxx |    1 -
 filter/source/msfilter/msvbasic.cxx  |    2 --
 filter/source/msfilter/msvbasic.hxx  |    2 --
 filter/source/msfilter/svxmsbas.cxx  |    1 -
 5 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index 44a0a7e..5b2e6fc 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -28,7 +28,7 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_filter.hxx"
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
+
 #include <com/sun/star/embed/Aspects.hpp>
 
 #include <math.h>
diff --git a/filter/source/msfilter/msocximex.cxx b/filter/source/msfilter/msocximex.cxx
index 722c7b9..e9032c2 100644
--- a/filter/source/msfilter/msocximex.cxx
+++ b/filter/source/msfilter/msocximex.cxx
@@ -29,7 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_filter.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
 #include <com/sun/star/uno/Any.h>
 #include <com/sun/star/text/VertOrientation.hpp>
 #include <com/sun/star/text/XText.hpp>
diff --git a/filter/source/msfilter/msvbasic.cxx b/filter/source/msfilter/msvbasic.cxx
index f39d793..41f4f5e 100644
--- a/filter/source/msfilter/msvbasic.cxx
+++ b/filter/source/msfilter/msvbasic.cxx
@@ -29,8 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_filter.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #include <string.h> // memset(), ...
 #ifndef UNX
 #include <io.h> // access()
diff --git a/filter/source/msfilter/msvbasic.hxx b/filter/source/msfilter/msvbasic.hxx
index f010741..b79ed0d 100644
--- a/filter/source/msfilter/msvbasic.hxx
+++ b/filter/source/msfilter/msvbasic.hxx
@@ -26,8 +26,6 @@
  *
  ************************************************************************/
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #ifndef _MSVBASIC_HXX
 #define _MSVBASIC_HXX
 
diff --git a/filter/source/msfilter/svxmsbas.cxx b/filter/source/msfilter/svxmsbas.cxx
index 84753bd..6cbf6a3 100644
--- a/filter/source/msfilter/svxmsbas.cxx
+++ b/filter/source/msfilter/svxmsbas.cxx
@@ -29,7 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_filter.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
 #include <tools/debug.hxx>
 #include <sfx2/objsh.hxx>
 #include <sfx2/app.hxx>
--
1.7.1

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PATCH] libs-core: Remove emacs modelines in the middle of the file

In reply to this post by spaetz

Signed-off-by: Sebastian Spaeth <[hidden email]>
---
 editeng/source/rtf/rtfgrf.cxx  |    1 -
 editeng/source/rtf/rtfitem.cxx |    2 --
 editeng/source/rtf/svxrtf.cxx  |    3 ---
 3 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/editeng/source/rtf/rtfgrf.cxx b/editeng/source/rtf/rtfgrf.cxx
index 2a9ce93..96c5293 100644
--- a/editeng/source/rtf/rtfgrf.cxx
+++ b/editeng/source/rtf/rtfgrf.cxx
@@ -29,7 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_editeng.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
 #include <osl/endian.h>
 #include <tools/cachestr.hxx>
 #include <vcl/graph.hxx>
diff --git a/editeng/source/rtf/rtfitem.cxx b/editeng/source/rtf/rtfitem.cxx
index d8a90aa..a1fa4aa 100644
--- a/editeng/source/rtf/rtfitem.cxx
+++ b/editeng/source/rtf/rtfitem.cxx
@@ -29,8 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_editeng.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #include <editeng/flstitem.hxx>
 #include <editeng/fontitem.hxx>
 #include <editeng/postitem.hxx>
diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx
index 605753f..e9bc5e7 100644
--- a/editeng/source/rtf/svxrtf.cxx
+++ b/editeng/source/rtf/svxrtf.cxx
@@ -29,9 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_editeng.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
-
 #include <ctype.h>
 #include <tools/datetime.hxx>
 #include <rtl/tencinfo.h>
--
1.7.1

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PATCH] libs-gui: Remove emacs modelines in the middle of the file

In reply to this post by spaetz

Signed-off-by: Sebastian Spaeth <[hidden email]>
---
 svtools/inc/rtftoken.h            |    2 --
 svtools/inc/svtools/svparser.hxx  |    2 --
 svtools/source/svrtf/parrtf.cxx   |    2 --
 svtools/source/svrtf/rtfkey2.cxx  |    2 --
 svtools/source/svrtf/rtfkeywd.cxx |    2 --
 svtools/source/svrtf/svparser.cxx |    1 -
 6 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/svtools/inc/rtftoken.h b/svtools/inc/rtftoken.h
index a237fa3..0d8dac0 100644
--- a/svtools/inc/rtftoken.h
+++ b/svtools/inc/rtftoken.h
@@ -26,8 +26,6 @@
  *
  ************************************************************************/
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #ifndef _RTFTOKEN_H
 #define _RTFTOKEN_H
 
diff --git a/svtools/inc/svtools/svparser.hxx b/svtools/inc/svtools/svparser.hxx
index 04f477e..3a403b2 100644
--- a/svtools/inc/svtools/svparser.hxx
+++ b/svtools/inc/svtools/svparser.hxx
@@ -26,8 +26,6 @@
  *
  ************************************************************************/
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #ifndef _SVPARSER_HXX
 #define _SVPARSER_HXX
 
diff --git a/svtools/source/svrtf/parrtf.cxx b/svtools/source/svrtf/parrtf.cxx
index 85861de..23f5c7a 100644
--- a/svtools/source/svrtf/parrtf.cxx
+++ b/svtools/source/svrtf/parrtf.cxx
@@ -29,8 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_svtools.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #include <stdio.h>                // for EOF
 #include <rtl/tencinfo.h>
 #include <tools/stream.hxx>
diff --git a/svtools/source/svrtf/rtfkey2.cxx b/svtools/source/svrtf/rtfkey2.cxx
index 187a9c0..0151660 100644
--- a/svtools/source/svrtf/rtfkey2.cxx
+++ b/svtools/source/svrtf/rtfkey2.cxx
@@ -29,8 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_svtools.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #include "rtfkeywd.hxx"
 
 sal_Char const SVTOOLS_CONSTASCII_DEF( sRTF_HEXCHAR, "\\'" );
diff --git a/svtools/source/svrtf/rtfkeywd.cxx b/svtools/source/svrtf/rtfkeywd.cxx
index d4392c4..5d2b9c0 100644
--- a/svtools/source/svrtf/rtfkeywd.cxx
+++ b/svtools/source/svrtf/rtfkeywd.cxx
@@ -29,8 +29,6 @@
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_svtools.hxx"
 
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
-
 #include "rtfkeywd.hxx"
 #include "rtftoken.h"
 #include "tools/string.hxx"
diff --git a/svtools/source/svrtf/svparser.cxx b/svtools/source/svrtf/svparser.cxx
index 2425778..c276ffd 100644
--- a/svtools/source/svrtf/svparser.cxx
+++ b/svtools/source/svrtf/svparser.cxx
@@ -28,7 +28,6 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_svtools.hxx"
-/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil -*- */
 
 #include <stdio.h>
 #include <svtools/svparser.hxx>
--
1.7.1

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PATCH] writer: Remove emacs modelines in the middle of the file

In reply to this post by spaetz

Signed-off-by: Sebastian Spaeth <[hidden email]>
---
 starmath/source/mathtype.cxx            |    2 --
 sw/source/filter/inc/msfilter.hxx       |    1 -
 sw/source/filter/inc/wwstyles.hxx       |    1 -
 sw/source/filter/ww8/WW8FibData.hxx     |    1 +
 sw/source/filter/ww8/writerhelper.hxx   |    1 -
 sw/source/filter/ww8/writerwordglue.cxx |    1 -
 sw/source/filter/ww8/writerwordglue.hxx |    1 -
 7 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/starmath/source/mathtype.cxx b/starmath/source/mathtype.cxx
index e21faa4..9721fad 100644
--- a/starmath/source/mathtype.cxx
+++ b/starmath/source/mathtype.cxx
@@ -30,9 +30,7 @@
 #include "precompiled_starmath.hxx"
 
 #include <mathtype.hxx>
-
 #include <osl/diagnose.h>
-
 #include <sfx2/docfile.hxx>
 
 #define APPEND(str,ascii) str.AppendAscii(RTL_CONSTASCII_STRINGPARAM(ascii))
diff --git a/sw/source/filter/inc/msfilter.hxx b/sw/source/filter/inc/msfilter.hxx
index 9eec3df..cfbe19a 100644
--- a/sw/source/filter/inc/msfilter.hxx
+++ b/sw/source/filter/inc/msfilter.hxx
@@ -25,7 +25,6 @@
  * for a copy of the LGPLv3 License.
  *
  ************************************************************************/
-/// @HTML
 
 #ifndef SW_MS_MSFILTER_HXX
 #define SW_MS_MSFILTER_HXX
diff --git a/sw/source/filter/inc/wwstyles.hxx b/sw/source/filter/inc/wwstyles.hxx
index 0daf91a..78ee771 100644
--- a/sw/source/filter/inc/wwstyles.hxx
+++ b/sw/source/filter/inc/wwstyles.hxx
@@ -26,7 +26,6 @@
  *
  ************************************************************************/
 
-/// @HTML
 #ifndef WW_WWSTYLES_HXX
 #define WW_WWSTYLES_HXX
 
diff --git a/sw/source/filter/ww8/WW8FibData.hxx b/sw/source/filter/ww8/WW8FibData.hxx
index d529998..0fd655d 100644
--- a/sw/source/filter/ww8/WW8FibData.hxx
+++ b/sw/source/filter/ww8/WW8FibData.hxx
@@ -25,6 +25,7 @@
  * for a copy of the LGPLv3 License.
  *
  ************************************************************************/
+
 #ifndef INCLUDED_WW8_FIB_DATA_HXX
 #define INCLUDED_WW8_FIB_DATA_HXX
 #include <IDocumentExternalData.hxx>
diff --git a/sw/source/filter/ww8/writerhelper.hxx b/sw/source/filter/ww8/writerhelper.hxx
index fed6f83..f758092 100644
--- a/sw/source/filter/ww8/writerhelper.hxx
+++ b/sw/source/filter/ww8/writerhelper.hxx
@@ -25,7 +25,6 @@
  * for a copy of the LGPLv3 License.
  *
  ************************************************************************/
-/// @HTML
 
 #ifndef SW_WRITERHELPER
 #define SW_WRITERHELPER
diff --git a/sw/source/filter/ww8/writerwordglue.cxx b/sw/source/filter/ww8/writerwordglue.cxx
index 5e2c418..315f2ed 100644
--- a/sw/source/filter/ww8/writerwordglue.cxx
+++ b/sw/source/filter/ww8/writerwordglue.cxx
@@ -28,7 +28,6 @@
 
 // MARKER(update_precomp.py): autogen include statement, do not remove
 #include "precompiled_sw.hxx"
-/// @HTML
 #include <msfilter.hxx>
 #   include "writerwordglue.hxx"
 #include <doc.hxx>
diff --git a/sw/source/filter/ww8/writerwordglue.hxx b/sw/source/filter/ww8/writerwordglue.hxx
index 09af0d9..b267ba3 100644
--- a/sw/source/filter/ww8/writerwordglue.hxx
+++ b/sw/source/filter/ww8/writerwordglue.hxx
@@ -25,7 +25,6 @@
  * for a copy of the LGPLv3 License.
  *
  ************************************************************************/
-/// @HTML
 
 #ifndef SW_WRITERWORDGLUE
 #define SW_WRITERWORDGLUE
--
1.7.1

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
spaetz spaetz
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Same patches as attachment

In reply to this post by spaetz
As Norbert Thiebaud has an email client that does not allow him to
nicely apply patches sent with "git send-email" ;-P, here the same 4
patches as attachments.

Thanks for applying.
Sebastian

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (203 bytes) Download Attachment
attachment1 (2K) Download Attachment
attachment2 (1K) Download Attachment
attachment3 (3K) Download Attachment
0001-Writer-Remove-emacs-modelines-in-the-middle-of-the-file.patch (3K) Download Attachment
Norbert Thiebaud Norbert Thiebaud
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [Pushed] Same patches as attachment

On Fri, Oct 29, 2010 at 1:36 AM, Sebastian Spaeth <[hidden email]> wrote:
> As Norbert Thiebaud has an email client that does not allow him to
> nicely apply patches sent with "git send-email" ;-P, here the same 4
> patches as attachments.

Pushed, Thanks

Norbert

>
> Thanks for applying.
> Sebastian
>
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>
>
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Easy Hack solved: Remove mid-file emacs modelines

In reply to this post by spaetz
On Fri, 2010-10-29 at 08:16 +0200, Sebastian Spaeth wrote:
> 4 patches following this patch for filters, libs-core, libs-gui, writer
> repositories killing all mid-file emacs modelines.
>
> If these are applied, I'll delete the corresponding easy hack on the
> wiki.

Could someone add a new wiki page called "Fixed Easy Hacks" or something
and move the done things in there, might have to go back through the
history of the "Easy Hacks" to pull out the old ones which got done.
Nice to have a list of the completed tasks.

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Joop Kiefte Joop Kiefte
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Easy Hack solved: Remove mid-file emacs modelines

The wiki is Mediawiki, isn't it? Mediawiki has version-control/history.

2010/10/29 Caolán McNamara <[hidden email]>:

> On Fri, 2010-10-29 at 08:16 +0200, Sebastian Spaeth wrote:
>> 4 patches following this patch for filters, libs-core, libs-gui, writer
>> repositories killing all mid-file emacs modelines.
>>
>> If these are applied, I'll delete the corresponding easy hack on the
>> wiki.
>
> Could someone add a new wiki page called "Fixed Easy Hacks" or something
> and move the done things in there, might have to go back through the
> history of the "Easy Hacks" to pull out the old ones which got done.
> Nice to have a list of the completed tasks.
>
> C.
>
> _______________________________________________
> LibreOffice mailing list
> [hidden email]
> http://lists.freedesktop.org/mailman/listinfo/libreoffice
>



--
Linux-user #496644 (http://counter.li.org) - first touch of linux in 2004

Demandoj en aŭ pri Esperanto? Questions about Esperanto? Vragen over
Esperanto? Perguntas sobre o Esperanto? - http://demandoj.tk
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Caio Tiago Oliveira Caio Tiago Oliveira
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Easy Hack solved: Remove mid-file emacs modelines

On Fri, Oct 29, 2010 at 1:28 PM, Joop Kiefte <[hidden email]> wrote:
> The wiki is Mediawiki, isn't it? Mediawiki has version-control/history.

It's better for new developers to see that information collected on a
page, though.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: Easy Hack solved: Remove mid-file emacs modelines

In reply to this post by Joop Kiefte
On Fri, 2010-10-29 at 13:28 -0300, Joop Kiefte wrote:
> The wiki is Mediawiki, isn't it? Mediawiki has version-control/history.

yes, but that's not really for reading, so I suggest it would be helpful
to quickly scan back over the mediawiki history/version control and note
the tasks which got removed because they were completed and stick them
on another CompletedEasyHacks page.

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...