[PATCH] Change in core[libreoffice-3-6-2]: fdo#44721 protect against negative calculated height value

Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/624

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/624/1

fdo#44721 protect against negative calculated height value

Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
---
M reportdesign/source/core/sdr/RptObject.cxx
1 file changed, 4 insertions(+), 2 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/624
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-2
Gerrit-Owner: Lionel Elie Mamane <[hidden email]>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Fri, Sep 14, 2012 at 04:00:15PM +0000, Lionel Elie Mamane (via Code Review) wrote:

>     https://gerrit.libreoffice.org/624

>     git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/24/624/1

> fdo#44721 protect against negative calculated height value

> Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360


These negative value were causing underflow when converted to
unsigned, and thus a very, very long loop in the drawing code, thus
equivalent to freeze for the user.

--
Lionel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

Thank you for your patch! :-)  It has been merged to LibreOffice.

If you are interested in details, please visit

    https://gerrit.libreoffice.org/624

Approvals:
  Michael Meeks: Verified; Looks good to me, approved


--
To view, visit https://gerrit.libreoffice.org/624
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4faedd535421eaf1e3e425f4731b3bb8831e7360
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6-2
Gerrit-Owner: Lionel Elie Mamane <[hidden email]>
Gerrit-Reviewer: Michael Meeks <[hidden email]>

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Fri, 2012-09-14 at 16:00 +0000, Lionel Elie Mamane wrote:
>     https://gerrit.libreoffice.org/624
...
> fdo#44721 protect against negative calculated height value

        Drat - I didn't notice this was vs the -3-6-2 branch (somehow) and
submitted it without another couple of sanity checks; it'd be great if
others could step in and provide them.

        Thanks !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Mon, Sep 17, 2012 at 10:55:08AM +0100, Michael Meeks <[hidden email]> wrote:
> Drat - I didn't notice this was vs the -3-6-2 branch (somehow) and
> submitted it without another couple of sanity checks; it'd be great if
> others could step in and provide them.

Looks correct to me.

Miklos
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice