Quantcast

[PATCH] Change of the color of the watermark at the pdfexport

classic Classic list List threaded Threaded
7 messages Options
Andreas Mantke Andreas Mantke
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] Change of the color of the watermark at the pdfexport

Hi,

there is a new option inside the code of the pdfexport of LO/OOo, which sets a
watermark on the exported document. This watermark is currently red. This is a bit
uggly and I think a light green matches better to LO. So I created a patch with this
color change.

Regards,
Andreas
--
## Developer LibreOffice
## Freie Office-Suite für Linux, Mac, Windows
## http://LibreOffice.org
## Support the Document Foundation (http://documentfoundation.org)
## Meine Seite: http://www.amantke.de 

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-A-change-in-the-color-of-the-watermark.patch (936 bytes) Download Attachment
Thorsten Behrens Thorsten Behrens
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Andreas Mantke wrote:
> there is a new option inside the code of the pdfexport of LO/OOo, which sets a
> watermark on the exported document. This watermark is currently red. This is a bit
> uggly and I think a light green matches better to LO.
>
Beautiful, pushed - congrats, your first code change is in! :)

What would you be interested to work on next? A list of ideas is
here: http://wiki.documentfoundation.org/Development/Easy_Hacks

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Andrea Pescetti Andrea Pescetti
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Thorsten Behrens wrote:
> Andreas Mantke wrote:
> > there is a new option inside the code of the pdfexport of LO/OOo, which sets a
> > watermark on the exported document. This watermark is currently red. This is a bit
> > uggly and I think a light green matches better to LO.
> >
> Beautiful, pushed - congrats, your first code change is in! :)

Take this just as a comment and not criticism (I congratulate with
Andreas too for his first patch!), but replacing a hard-coded value by
another hard-coded value on the basis that, more or less, "Green is
nicer and it matches the LibreOffice official color" seems a bit weak to
me.

Maybe better check with one of the UX people? Or provide a
UI-configurable choice? I can't help with either at the moment,
unfortunately.

Best regards,
  Andrea.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andreas Mantke Andreas Mantke
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Hi Andrea, Thorsten, *,

Am Dienstag, 21. Dezember 2010, 23:01:13 schrieb Andrea Pescetti:

(...)
> Take this just as a comment and not criticism (I congratulate with
> Andreas too for his first patch!), but replacing a hard-coded value by
> another hard-coded value on the basis that, more or less, "Green is
> nicer and it matches the LibreOffice official color" seems a bit weak to
> me.
>

I did the change because the former color (red) caused problems in reading the
document.
Your point about a configurable color is valuable, but I think that is not an easy
hack. I'll think about a way. Maybe someone is faster then I ;-)

> Maybe better check with one of the UX people? Or provide a
> UI-configurable choice? I can't help with either at the moment,
> unfortunately.

You can't reach the option currently via UI. The pdf-export-dialog doesn't cover the
option "Watermark". It's available only on the command-line via UNO-API.

Regards,
Andreas
--
## Developer LibreOffice
## Freie Office-Suite für Linux, Mac, Windows
## http://LibreOffice.org
## Support the Document Foundation (http://documentfoundation.org)
## Meine Seite: http://www.amantke.de 
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Cor Nouws Cor Nouws
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Hi *,

Andreas Mantke wrote (22-12-10 17:52)

> Am Dienstag, 21. Dezember 2010, 23:01:13 schrieb Andrea Pescetti:
>
> (...)
>> Take this just as a comment and not criticism (I congratulate with
>> Andreas too for his first patch!), but replacing a hard-coded value by
>> another hard-coded value on the basis that, more or less, "Green is
>> nicer and it matches the LibreOffice official color" seems a bit weak to
>> me.
>
> I did the change because the former color (red) caused problems in reading the
> document.
> Your point about a configurable color is valuable, but I think that is not an easy
> hack. I'll think about a way. Maybe someone is faster then I ;-)

The same applies of course for the default colors of Impress tables,
that were changed recently.
If not via the UI, some xcu file (or sog?) would be at least a start to
make it configurable (for those 'brave' enough to change those files).


Best - Cor

--
  - giving openoffice.org its foundation :: The Document Foundation -

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrea Pescetti Andrea Pescetti
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Cor Nouws wrote:
> The same applies of course for the default colors of Impress tables,
> that were changed recently.

This seems a different situation: you can change the color of a table if
the default does not suit your needs, so if you want blue tables
(default in OpenOffice.org) you can perfectly recolor a gray table
(default in LibreOffice) via UI; but, provided I understood Andreas'
remarks correctly, in this case you cannot change the watermark color
via UI or even via command-line, since its value is hardcoded in the
source and cannot be changed by the user.

Regards,
  Andrea.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Cor Nouws Cor Nouws
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED] Change of the color of the watermark at the pdfexport

Hi Andrea,

Andrea Pescetti wrote (23-12-10 01:17)

> Cor Nouws wrote:
>> The same applies of course for the default colors of Impress tables,
>> that were changed recently.
>
> This seems a different situation: you can change the color of a table if
> the default does not suit your needs, so if you want blue tables
> (default in OpenOffice.org) you can perfectly recolor a gray table
> (default in LibreOffice) via UI; but, provided I understood Andreas'
> remarks correctly, in this case you cannot change the watermark color
> via UI or even via command-line, since its value is hardcoded in the
> source and cannot be changed by the user.

Yes, thats true,

Cor

--
  - giving openoffice.org its foundation :: The Document Foundation -

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...