Document Foundation Mail Archive › LibreOffice › Dev

[PATCH] Converting code to STL in SVX module

Classic

List

Threaded

2 messages Options

Noel Grandin

[PATCH] Converting code to STL in SVX module

Hi

Just when I thought I was done, more of the stuff crawls out.....

These patches pass a full make check.

Regards,
Noel Grandin

Disclaimer: http://www.peralex.com/disclaimer.html

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0009-Remove-unused-class-ContainerSorter.patch (3K) Download Attachment

0010-Convert-aList-in-class-_SdrItemBrowserControl-from-C.patch (7K) Download Attachment

0011-Remove-unnecessary-include.patch (1K) Download Attachment

0012-Remove-unnecessary-include.patch (890 bytes) Download Attachment

0013-Convert-aList-in-SdrGluePointList-class-from-Contain.patch (5K) Download Attachment

0014-Convert-aList-field-in-SdrHelpLineList-class-from-Co.patch (5K) Download Attachment

0015-Convert-aLayer-field-in-SdrLayerAdmin-class-from-Con.patch (9K) Download Attachment

0001-Convert-aPnts-field-in-SdrDragStat-class-from-Contai.patch (5K) Download Attachment

0002-Convert-OLEObjCache-class-from-Container-to-std-vect.patch (8K) Download Attachment

0003-Convert-aList-field-in-SdrLinkList-class-from-Contai.patch (4K) Download Attachment

0004-Remove-unused-class-UShortCont.patch (2K) Download Attachment

0005-Remove-unused-class-ImpUShortContainerSorter.patch (1K) Download Attachment

0006-Convert-SdrUShortCont-from-Container-to-std-set.patch (51K) Download Attachment

0007-Convert-maList-in-SdrMarkList-from-Container-to-std-.patch (13K) Download Attachment

0008-Convert-aList-in-SdrHdlList-class-from-Container-to-.patch (14K) Download Attachment

Michael Stahl-2

[PUSHED] Re: [PATCH] Converting code to STL in SVX module

On 15/08/12 14:08, Noel Grandin wrote:
> Hi
>
> Just when I thought I was done, more of the stuff crawls out.....
>
> These patches pass a full make check.

thanks, pushed

patch #10 has this, which (since the Remove is, uhm, removed) will
delete the same entry multiple times... also previously the elements
were removed at the end, now at the begin

> - if (aList.Count()>nEntryNum) { // maybe still too many entries
> - sal_uIntPtr nTooMuch=aList.Count()-nEntryNum;
> + if (aList.size()>nEntryNum) { // maybe still too many entries
> + sal_uIntPtr nTooMuch=aList.size()-nEntryNum;
> for (sal_uIntPtr nNum=0; nNum<nTooMuch; nNum++) {
> delete ImpGetEntry(nEntryNum);
> - aList.Remove(nEntryNum);
> }
> + aList.erase(aList.begin(), aList.begin() + nTooMuch);

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice