[PATCH] [REVIEW:3-5] fdo#36824 embedded hsqldb; in view computed row without alias makes whole file unusable

hsqldb fails to properly escape column names it generates
automatically from an expression in the "script" file it uses to
recreate the database (in memory) on load/connect.

The net effect is that any .odb file where such a view has been
defined cannot be reopened, unless one manually fiddles with the
database/script file in the .odb file seen as a zip file.

This patch fixes that, by saying that *any* expression that is not
already a column name *should* be escaped (instead of *not* escaped)
when seen as a column name/alias.

I hope no bad side-effects, but I'm not intimate with HSQLDB internals,
so never can be really sure.

Please apply to libreoffice-3-5.

--
Lionel

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Tue, Jul 03, 2012 at 08:42:03PM +0200, Lionel Elie Mamane <[hidden email]> wrote:
Looks sane, pushed to -3-5.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice