[PATCH] [REVIEW:3-5] fdo#47473 legacy reports created in 3.5 fail to open

Legacy reports (not Sun/Oracle Report Builder ones) created by the
wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
and later): show empty data.

To correct i#98163, LibO 3.5 leaves the Command hidden control value
empty, this is the signal that on opening, it should fetch the current
definition of the query (in QueryName hidden control); that change is
inherited from a OO.org 3.4 CWS...

The problem was within the prependSortCriteria() method call. It tries
to use (deeper withing subobjects) metadata about columns that gets
initialised only at ->execute time, and thus all this code raised an
exception (null pointer). So I moved it to after the execute(), but
then we have to ->execute again so that it gets taken into
account... Hmmm... There is probably a better solution, but this one
works for now.


Please apply to libreoffice-3-5 branch.

--
Lionel

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Tue, Jun 05, 2012 at 10:11:23PM +0200, Lionel Elie Mamane wrote:
> Legacy reports (not Sun/Oracle Report Builder ones) created by the
> wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
> and later): show empty data.

> Please apply to libreoffice-3-5 branch.

Wait... I causes a build failure on MOX.

--
Lionel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Wed, Jun 06, 2012 at 06:11:31AM +0200, Lionel Elie Mamane wrote:
> On Tue, Jun 05, 2012 at 10:11:23PM +0200, Lionel Elie Mamane wrote:

>> Legacy reports (not Sun/Oracle Report Builder ones) created by the
>> wizard in LibreOffice 3.5 or later fail to open (in LibreOffice 3.5
>> and later): show empty data.

>> Please apply to libreoffice-3-5 branch.

> Wait... I causes a build failure on MOX.

Here's the fix by Norbert. Please apply both the original patch and
the fix. Thanks. (And somebody find me a brown paper bag...)

--
Lionel

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Wed, Jun 06, 2012 at 06:21:43AM +0200, Lionel Elie Mamane wrote:
> (And somebody find me a brown paper bag...)

Here you have one from my collection!

Best,

Bjoern
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Wed, 2012-06-06 at 06:21 +0200, Lionel Elie Mamane wrote:
> Here's the fix by Norbert. Please apply both the original patch and
> the fix. Thanks. (And somebody find me a brown paper bag...)

Pushed to 3-5

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice