[PATCH] WaE in ScTabViewShell::UpdateNumberFormatter

Hi,

this patch solves WaE unused pDoc parameter in
ScTabViewShell::UpdateNumberFormatter.
I have no idea, why I'm getting it now, git blame says that the last
changes in this file were years ago ...

Regards
David

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 06/07/2012 05:05 PM, David Ostrovsky wrote:

Hi,

this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter.
I have no idea, why I'm getting it now, git blame says that the last changes in this file were years ago ...

Regards
David 

Hi, David,

I can't open your attached file.  It has a .swp extension?

I think the warning was a result of http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a774815a24d3f55a64d901a1266e4543a2a2930 .

Thomas was removing unused code and looks like removing the ScDocument* pDoc parameter of ScTabViewShell::UpdateNumberFormatter was forgotten.


Respectfully,
Daniel Bankston

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Daniel,

trying to send it to once time again.

Regards
David

On 08.06.2012 01:35, Daniel Bankston wrote:

On 06/07/2012 05:05 PM, David Ostrovsky wrote:

Hi,

this patch solves WaE unused pDoc parameter in ScTabViewShell::UpdateNumberFormatter.
I have no idea, why I'm getting it now, git blame says that the last changes in this file were years ago ...

Regards
David 

Hi, David,

I can't open your attached file.  It has a .swp extension?

I think the warning was a result of http://cgit.freedesktop.org/libreoffice/core/commit/?id=3a774815a24d3f55a64d901a1266e4543a2a2930 .

Thomas was removing unused code and looks like removing the ScDocument* pDoc parameter of ScTabViewShell::UpdateNumberFormatter was forgotten.


Respectfully,
Daniel Bankston

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Arg sorry for this...

On Thu, 07 Jun 2012 18:35:05 -0500, Daniel Bankston wrote:
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 06/08/2012 01:14 AM, David Ostrovsky wrote:

Hi Daniel,

trying to send it to once time again.

Regards
David

Looks good to me, but please let someone else concur (preferably one of the calc gurus).

Respectfully,
Daniel Bankston

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 06/08/2012 01:17 AM, Thomas Arnhold wrote:
> Arg sorry for this...
Thomas,

I don't think it's that big of a worry.  Although, perhaps it would have
been better to submit the revised version of the patch to the mailing
list before pushing.  David caught it, though, so no worries.  This is
part of what open source is all about, right?  We look out for each
other.  Didn't someone once say something along the lines, "given enough
eyeballs, all bugs are shallow"?  :-)

Respectfully,
Daniel Bankston
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 06/08/2012 12:05 AM, David Ostrovsky wrote:
> this patch solves WaE unused pDoc parameter in
> ScTabViewShell::UpdateNumberFormatter.
> I have no idea, why I'm getting it now, git blame says that the last
> changes in this file were years ago ...

Oops, sorry, only discovered this thread now that I have already pushed
a fix myself (and nudged Thomas towards --enable-werror in the original
patch's thread).  If I had seen David's patch earlier, I would of course
have pushed it with his authorship (as it happens, our two patches turn
out to be exactly the same, anyway).

Stephan
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Daniel,

On Friday, 2012-06-08 01:32:26 -0500, Daniel Bankston wrote:

> Looks good to me, but please let someone else concur (preferably one
> of the calc gurus).

All fine, a leftover from dead code removal.

Thanks
  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice