On 06/08/2012 01:17 AM, Thomas Arnhold wrote:
> Arg sorry for this...
I don't think it's that big of a worry. Although, perhaps it would have
been better to submit the revised version of the patch to the mailing
list before pushing. David caught it, though, so no worries. This is
part of what open source is all about, right? We look out for each
other. Didn't someone once say something along the lines, "given enough
eyeballs, all bugs are shallow"? :-)
On 06/08/2012 12:05 AM, David Ostrovsky wrote:
> this patch solves WaE unused pDoc parameter in
> I have no idea, why I'm getting it now, git blame says that the last
> changes in this file were years ago ...
Oops, sorry, only discovered this thread now that I have already pushed
a fix myself (and nudged Thomas towards --enable-werror in the original
patch's thread). If I had seen David's patch earlier, I would of course
have pushed it with his authorship (as it happens, our two patches turn
out to be exactly the same, anyway).