Quantcast

[PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

classic Classic list List threaded Threaded
7 messages Options
Florent Gallaire Florent Gallaire
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

I think this patch is clean. I hope Eike Rathke will agree.

Best regards

Florent

--
FLOSS Engineer & Lawyer

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0001-fdo-45664-EasyHack-Add-a-Save-cell-formulas-checkbox.patch (14K) Download Attachment
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

Hi Florent,

On Monday, 2012-04-23 04:47:50 +0200, Florent Gallaire wrote:

> I think this patch is clean.

Hey, great, thanks!
It didn't apply cleanly as some of the surrounding code lines were
changed in the mean time, but pushed with
http://cgit.freedesktop.org/libreoffice/core/commit/?id=c041db6f59888adc90ee8257eafe150d874c46c9

> I hope Eike Rathke will agree.

Well, almost ;-)
For my nitpicks please see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3cceb8a900cd1fe1ae9bdb0c2e532e82a1835861

Main change is that the "Save cell content as shown" option is
independent of the "Save formulas" option and should not be disabled
when checking that. I also made the initial state depend on the "Show
formulas" view option.

As this seems to be your first contribution to the code base could you
please send a blanket statement to the mailing list (preferably in this
thread) that you contribute this and further patches under LGPLv3+ and
MPL 1.1 licenses? After having done so you may also want to add yourself
to https://wiki.documentfoundation.org/Development/Developers and in the
License column point to that mail in the archive.

Thanks for the patch, I hope we see more from you :-)

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Florent Gallaire Florent Gallaire
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

Thanks for the commit Eike, I'm really proud and grateful !

> Main change is that the "Save cell content as shown" option is
> independent of the "Save formulas" option and should not be disabled
> when checking that.

I disagree, and I will try to explain myself :
When you export a cell with =DATE(1981;9;20) by values, you have :
1) 20/09/81 when "Save cell content as shown" is set
2) 29849  when "Save cell content as shown" is not set
When you export the same cell by formulas, you always have
=DATE(1981;9;20), regardless the "Save cell content as shown" option.
As this option is no more relevant in this context , for a good user
experience, she should be disabled, this is an information for the
user.

> I also made the initial state depend on the "Show
> formulas" view option.

OK, I was thinking to do that in a second time, after the validation
of this patch, so thanks a lot this is already done !

Florent

--
FLOSS Engineer & Lawyer
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Florent Gallaire Florent Gallaire
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

In reply to this post by Eike Rathke-2
I, Florent Gallaire, as the only author of all the source code that I
send to the LibreOffice project, I contribute this and further patches
under LGPLv3+ and MPL 1.1 licenses.

Florent Gallaire
Paris, France
april 26, 2012

--
FLOSS Engineer & Lawyer
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

In reply to this post by Florent Gallaire
Hi Florent,

On Thursday, 2012-04-26 04:29:03 +0200, Florent Gallaire wrote:

> Thanks for the commit Eike, I'm really proud and grateful !

:-)

> > Main change is that the "Save cell content as shown" option is
> > independent of the "Save formulas" option and should not be disabled
> > when checking that.
>
> I disagree, and I will try to explain myself :
> When you export a cell with =DATE(1981;9;20) by values, you have :
> 1) 20/09/81 when "Save cell content as shown" is set
> 2) 29849  when "Save cell content as shown" is not set
> When you export the same cell by formulas, you always have
> =DATE(1981;9;20), regardless the "Save cell content as shown" option.
> As this option is no more relevant in this context , for a good user
> experience, she should be disabled, this is an information for the
> user.
That behavior is only with formula cells though. Value cells without
formulas are still affected by the option; without being checked the raw
value is exported, when checked the value is exported as displayed by
the number format applied. If you have a good idea how that could be
clarified for the user I'd welcome your patch :-)  Maybe just some
rewording of the option is needed?

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Florent Gallaire Florent Gallaire
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

> That behavior is only with formula cells though. Value cells without
> formulas are still affected by the option; without being checked the raw
> value is exported, when checked the value is exported as displayed by
> the number format applied.

You are right !

> If you have a good idea how that could be
> clarified for the user I'd welcome your patch :-)  Maybe just some
> rewording of the option is needed?

Probably the problem is the global calc behaviour and won't be fixed.
For me "=4/2" is the number "2", and "4/2" should always be the string
"4/2" and never the evil "02/04/12", which should only be the result
of "=DATE(2012;2;4)".

Florent

--
FLOSS Engineer & Lawyer
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [PUSHED][PATCH] fdo#45664 EasyHack: Calc can't export the cells formulas to CSV (only the cells values)

Hi Florent,

On Saturday, 2012-04-28 06:53:34 +0200, Florent Gallaire wrote:

> Probably the problem is the global calc behaviour and won't be fixed.

Wrong ;-)  It is already fixed with the locale dependent date acceptance
patterns recently implemented. Anyway, this is not really related to the
"export as shown" option that is general to all number formats.

> For me "=4/2" is the number "2", and "4/2" should always be the string
> "4/2" and never the evil "02/04/12", which should only be the result
> of "=DATE(2012;2;4)".

Actually no. In en_US locale it is expected that the input of 4/2
results in 04/02/12, of course that is not desired in other locales that
use a different date separator. What the fix mentioned is about. For
details see
http://erack.org/blog/archives/8-LibreOffice-date-acceptance-patterns.html

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Loading...