Document Foundation Mail Archive › LibreOffice › Dev

[PATCH] fix dead code and fields in Java code

Classic

List

Threaded

3 messages Options

Noel Grandin

[PATCH] fix dead code and fields in Java code

Hi

These patches remove various bits of dead code in the Java files.

Regards, Noel Grandin

Disclaimer: http://www.peralex.com/disclaimer.html

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

0002-fix-dead-assignment-in-setRowStyle.patch (1K) Download Attachment

0003-Remove-dead-java-code-fields-and-local-variables.patch (61K) Download Attachment

0004-Remove-dead-java-code.patch (7K) Download Attachment

0005-Remove-dead-java-code-fields-and-local-variables.patch (53K) Download Attachment

0001-Java-update-remove-dead-code.patch (7K) Download Attachment

Caolán McNamara

Re: [PUSHED][PATCH] fix dead code and fields in Java code

On Fri, 2012-08-17 at 17:15 +0200, Noel Grandin wrote:
> Hi
>
> These patches remove various bits of dead code in the Java files.

With one trivial change built and passed make check for me, pushed now

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Stephan Bergmann-2

Re: [PUSHED][PATCH] fix dead code and fields in Java code

On 08/20/2012 05:37 PM, Caolán McNamara wrote:
> On Fri, 2012-08-17 at 17:15 +0200, Noel Grandin wrote:
>> These patches remove various bits of dead code in the Java files.
>
> With one trivial change built and passed make check for me, pushed now

With Java's reflection mechanisms, it is hard to tell whether a field is
really unused---even if it is private---, but

> --- a/javaunohelper/com/sun/star/comp/JavaUNOHelperServices.java
> +++ b/javaunohelper/com/sun/star/comp/JavaUNOHelperServices.java
> @@ -29,9 +29,6 @@ import com.sun.star.comp.juhtest.SmoketestCommandEnvironment;
> */
> public class JavaUNOHelperServices {
>
> - static private final String __service_smoketestCommandEnv =
> - "com.sun.star.deployment.test.SmoketestCommandEnvironment";
> -
> /**
> * Gives a factory for creating the service.
> * This method is called by the <code>JavaLoader</code>

appears to have been of no use indeed (at least, smoketest still works).

Stephan
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice