[PATCH] newdev review request: sc/.../vbarange.cxx

Hullo List,

Having been too excited last time (7+ months) and committed to master
way too early, I'm back to basics as I try (once again) to get back into
LO dev.  Here's a minor cppcheck-found unused variable patch.  Please
review at your convenience.

Cheers,

Kevin

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 06/06/12 17:41, Kevin Hunter wrote:
> Hullo List,
>
> Having been too excited last time (7+ months) and committed to master
> way too early, I'm back to basics as I try (once again) to get back
> into LO dev.  Here's a minor cppcheck-found unused variable patch.  
> Please review at your convenience.
>
Patch looks fine, thanks for that, pushed now. Btw if you are interested
there are probably quite a few instances of  VBA_OOBUILD_HACK buried in
there that could do with removal ( and then finally wherever the -D for
same passed to the compiler ) Cleaning those out would be appreciated (
by me at least ) Next time for convenience could you use 'git
format-patch' for creating the diff ( just makes it easier to process )
thanks alot !!

Noel
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

At 4:40am -0400 Thu, 07 Jun 2012, Noel Power wrote:
> Btw if you are interested there are probably quite a few instances
> of VBA_OOBUILD_HACK buried in there that could do with removal ( and
> then finally wherever the -D for same passed to the compiler )
> Cleaning those out would be appreciated ( by me at least )

Noted.  Will see what comes up.

> Patch looks fine, thanks for that, pushed now.

> Next time for convenience could you use 'git format-patch' for
> creating the diff ( just makes it easier to process ) thanks alot !!

I actually have commit access.  I just ... jumped the gun when I was
working on removing the mpNote pointer from ScBaseCell 7 months ago.
Now I'm timid again, and until I get more confidence for anything more
than a /dead/ simple patch, I'm nervous.

And so it goes.  Thanks!

Kevin
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice