[ Patch ] fdo#49750 Search Findbar's History

Hi,

    This patch make the mentioned Toolbar to remember the searched  
strings after
closing and reopening. Details in patch description.


Regards,
Zolnai Tamás
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Tamás,

On Wed, Aug 08, 2012 at 09:35:26PM +0200, [hidden email] wrote:
>    This patch make the mentioned Toolbar to remember the searched
> strings after
> closing and reopening. Details in patch description.

Great, thanks for this!

Pushed now to master.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Tamas, Miklos,

Miklos Vajna píše v Čt 09. 08. 2012 v 09:36 +0200:

> >    This patch make the mentioned Toolbar to remember the searched
> > strings after
> > closing and reopening. Details in patch description.
>
> Great, thanks for this!

Indeed, thank you!  I started integrating this, but Miklos was
faster :-)

I have small nitpicks, so I've pushed that as a minor follow-up cleanup:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=9c9cf6ed4a64fd5f26e15d87d2745309d681aa2e

m_ means "member" - we are using that to mark the member variables, so I
changed the naming a bit; added that to the aSearchStrings, and removed
from m_pFindTextFieldControl wherever it is used as a function
parameter.

The other, even more minor thing, was the whitespace - wrong indentation
in one case.

Otherwise your patch works perfectly, thank you again!

All the best,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi Kendy,

   Thanks for the correction! I'll pay attention these things in the future!


Regards,
Zolnai Tamás



_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice