Quantcast

[REVIEW 3-5-5] Request sign-off for crash fix

classic Classic list List threaded Threaded
5 messages Options
Lionel Dricot Lionel Dricot
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[REVIEW 3-5-5] Request sign-off for crash fix

Hello,

A crash has been fixed and Markus Mohrhard gave his sign-off to include
it in 3.5.6.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=17c85c9a5c447f9db6f3b91e6840709df8542345&g=libreoffice-3-5

Because it fixes a crash which leads to a loss of data (any unsaved data
is lost), I thought it might worth including it in 3.5.5 too. Could two
more developers give their sign-off for that ?


Sorry for not being very efficient with the LO process yet.


Lionel

PS: please put me in CC when replying
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-2 Michael Meeks-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-5] Request sign-off for crash fix


On Fri, 2012-06-22 at 11:11 +0200, Lionel Dricot wrote:
> A crash has been fixed and Markus Mohrhard gave his sign-off to include
> it in 3.5.6.
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=17c85c9a5c447f9db6f3b91e6840709df8542345&g=libreoffice-3-5

        Looks great to me :-) thanks for that; we just re-write it out in this
case; so you have my +1.

        One more, and you can push to libreoffice-3-5-5 (worth adding the
sign-off lines manually).

        Thanks !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Eike Rathke-2 Eike Rathke-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-5] Request sign-off for crash fix

In reply to this post by Lionel Dricot
Hi,

On Friday, 2012-06-22 11:11:07 +0200, Lionel Dricot wrote:

> A crash has been fixed and Markus Mohrhard gave his sign-off to include
> it in 3.5.6.
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=17c85c9a5c447f9db6f3b91e6840709df8542345&g=libreoffice-3-5
>
> Because it fixes a crash which leads to a loss of data (any unsaved data
> is lost), I thought it might worth including it in 3.5.5 too. Could two
> more developers give their sign-off for that ?

Note that we only need one more sign-off, counting my own review as
such.. see also

Date: Fri, 22 Jun 2012 12:26:00 +0200
Subject: Re: [REVIEW 3-5-5] proposal of a patch to solve a crasher when saving a spreadsheet with track-change
From: Eike Rathke <[hidden email]>
Message-ID: <[hidden email]>

and thread.

  Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment
Norbert Thiebaud Norbert Thiebaud
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-5] Request sign-off for crash fix

On Fri, Jun 22, 2012 at 9:51 AM, Eike Rathke <[hidden email]> wrote:

> Hi,
>
> On Friday, 2012-06-22 11:11:07 +0200, Lionel Dricot wrote:
>
>> A crash has been fixed and Markus Mohrhard gave his sign-off to include
>> it in 3.5.6.
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=17c85c9a5c447f9db6f3b91e6840709df8542345&g=libreoffice-3-5
>>
>> Because it fixes a crash which leads to a loss of data (any unsaved data
>> is lost), I thought it might worth including it in 3.5.5 too. Could two
>> more developers give their sign-off for that ?

+1

Norbert
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks-2 Michael Meeks-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[PUSHED 3-5-5] Request sign-off for crash fix


        Found pushed to libreoffice-3-5-5.

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...