Quantcast

[REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

classic Classic list List threaded Threaded
7 messages Options
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

[REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

Hi,

this fixes https://bugs.freedesktop.org/show_bug.cgi?id=52610 and
https://bugs.freedesktop.org/show_bug.cgi?id=52612

It looks sane, works in 3-5 branch as well => pushed there.

I am not sure if this is worth the risk for 3.5.6-rc2. Anyway, two more
approvals could get it there.


Best Regards,
Petr


_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
ape ape
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

This post was updated on .
Hi, Petr!

It's nice news. But today I found by chance something else (ODF to DOCX then FILE REOPEN..), after fixing the
error by Cedric.
 Is there a need to create a new bug?
--
ape
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

ape píše v Po 06. 08. 2012 v 08:08 -0700:
> Good, but today I found by chance something else (ODF to DOCX then FILE
> REOPEN..), after fixing the
> error by Cedric. Is there a need to create a new bug?

Sure, please open a bug and write more details about the problem there.

Is it an older bug?
Or is it a regression caused by the Cedric's fix?


Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
ape ape
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

Hi, Petr!

1. OK: see https://bugs.freedesktop.org/show_bug.cgi?id=53175
2. This is new bug, but isn't the Cedric's mistake. Import bug became visible only after fixing the error of exports.

Best regards!
--
ape
Miklos Vajna-2 Miklos Vajna-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

In reply to this post by Petr Mladek
On Mon, Aug 06, 2012 at 04:42:17PM +0200, Petr Mladek <[hidden email]> wrote:
> this fixes https://bugs.freedesktop.org/show_bug.cgi?id=52610 and
> https://bugs.freedesktop.org/show_bug.cgi?id=52612
>
> It looks sane, works in 3-5 branch as well => pushed there.
>
> I am not sure if this is worth the risk for 3.5.6-rc2. Anyway, two more
> approvals could get it there.

+1 from me, one more still needed.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
ape ape
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REVIEW 3-5-6] fdo#52610: Fixed several docx export bugs

Hi, Miklos!

What do You think about this error: https://bugs.freedesktop.org/show_bug.cgi?id=52160
It is created for your comment https://bugs.freedesktop.org/show_bug.cgi?id=52071#c4.

Thanks. Best regards!
--
ape
Petr Mladek Petr Mladek
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [REJECTED 3-5-6] fdo#52610: Fixed several docx export bugs

In reply to this post by ape
ape píše v Po 06. 08. 2012 v 10:31 -0700:
> Hi, Petr!
>
> 1. OK: see https://bugs.freedesktop.org/show_bug.cgi?id=53175
> 2. This is new bug, but isn't the Cedric's mistake. Import bug became
> visible only after fixing the error of exports.

Ah, LO-3.5 crashed when loading the document after the 2nd save, see
https://bugs.freedesktop.org/show_bug.cgi?id=53175#c2

=> it is worse than the previous state => we need a better fix.

Hmm, I am afraid that it might break even other documents that worked
before => we can't use it for 3-5-6. We might even want to revert it in
the other branches until we have a better fix.

Cedric, could you please have a look?


Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...