[REVIEW-3-6-0] Fix for fdo#51943 toolbar floater bug on Mac

Hi there,

managed to fix $subject by adding another band-aid - fix behaves
well on Mac and Linux, barring bad side effects on Win, I'd *very*
much like to have this cherry-picked for 3-6-0 - commit is

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=94fdc1e684d691cd63d75685b5a607d35e737dcf

Thanks a lot,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Thorsten Behrens píše v Út 24. 07. 2012 v 13:39 +0200:
> Hi there,
>
> managed to fix $subject by adding another band-aid - fix behaves
> well on Mac and Linux, barring bad side effects on Win, I'd *very*
> much like to have this cherry-picked for 3-6-0 - commit is
>
>  http://cgit.freedesktop.org/libreoffice/core/commit/?id=94fdc1e684d691cd63d75685b5a607d35e737dcf

I can confirm that it works fine on Linux => +1

One more approval needed for 3-6-0, preferably from a Windows hacker.


Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Tue, 2012-07-24 at 15:04 +0200, Petr Mladek wrote:
> >  http://cgit.freedesktop.org/libreoffice/core/commit/?id=94fdc1e684d691cd63d75685b5a607d35e737dcf
>
> I can confirm that it works fine on Linux => +1
>
> One more approval needed for 3-6-0, preferably from a Windows hacker.

        As I said to Thorsten on IM, I'm concerned that this means we have to
manually pop-down the color selector if we don't want to select a color
(rather than just clicking something else, another drop-down /
whatever); which seems sub-optimal.

        OTOH - even if that is the case, it seems a lot better than not being
able to select text colors on OSX :-) so I'm a +1 too for 3.6.0

        Thanks !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Michael Meeks píše v Út 24. 07. 2012 v 14:25 +0100:
I still could close the color selector by clicking anywhere else => I do
not see any real-life change in the behavior.

> OTOH - even if that is the case, it seems a lot better than not being
> able to select text colors on OSX :-) so I'm a +1 too for 3.6.0

Exactly. Fridrich does not see any change in the behavior on Windows as
well => pushed into 3-6-0 branch.


Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On Tue, 2012-07-24 at 17:52 +0200, Petr Mladek wrote:
> I still could close the color selector by clicking anywhere else => I do
> not see any real-life change in the behavior.

        Great :-) wonder-fix Thorsten :-)

        Thanks !

                Michael.

--
[hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice