Document Foundation Mail Archive › LibreOffice › Dev

[REVIEW-3-6 3-6-0] fix for fdo#52393, calc does not import manual row heights

Classic

List

Threaded

5 messages Options

Markus Mohrhard

[REVIEW-3-6 3-6-0] fix for fdo#52393, calc does not import manual row heights

Hey,

[1] fixes the problem that calc does not import manual row heights in
3-6. We need to mark the rows as manual row height in the row flags to
prevent overriding them with automatic row height calculation. You
won't see this problem in master because we are not updating the row
heights there at the moment.

IMHO this is a fix for 3-6-0 because it is a quite serious issue.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=c55cfd273cf1d4666b91fc9a00c71b049c34adec
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Kohei Yoshida

Re: [REVIEW-3-6 3-6-0] [PUSHED 3-6] fix for fdo#52393, calc does not import manual row heights

On 07/26/2012 06:20 PM, Markus Mohrhard wrote:
> Hey,
>
> [1] fixes the problem that calc does not import manual row heights in
> 3-6. We need to mark the rows as manual row height in the row flags to
> prevent overriding them with automatic row height calculation. You
> won't see this problem in master because we are not updating the row
> heights there at the moment.
>
> IMHO this is a fix for 3-6-0 because it is a quite serious issue.

I agree. Pushed to the 3-6 branch with my sign-off.

I hope we can gather 2 more sign-offs on this. IMO we shouldn't release
3.6.0 without this fix.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Petr Mladek

Re: [REVIEW 3-6-0 2/3] fix for fdo#52393, calc does not import manual row heights

Kohei Yoshida píše v Čt 26. 07. 2012 v 21:06 -0400:

> On 07/26/2012 06:20 PM, Markus Mohrhard wrote:
> > Hey,
> >
> > [1] fixes the problem that calc does not import manual row heights in
> > 3-6. We need to mark the rows as manual row height in the row flags to
> > prevent overriding them with automatic row height calculation. You
> > won't see this problem in master because we are not updating the row
> > heights there at the moment.
> >
> > IMHO this is a fix for 3-6-0 because it is a quite serious issue.
>
> I agree. Pushed to the 3-6 branch with my sign-off.

+1 One more approval needed for 3-6-0.

> I hope we can gather 2 more sign-offs on this. IMO we shouldn't release
> 3.6.0 without this fix.

I agree.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Thorsten Behrens

Re: [PUSHED 3-6-0] fix for fdo#52393, calc does not import manual row heights

Petr Mladek wrote:
> +1 One more approval needed for 3-6-0.
>
Fixes the bug, pushed to 3-6-0

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment

Petr Mladek

Re: [PUSHED 3-6-0] fix for fdo#52393, calc does not import manual row heights

In reply to this post by Petr Mladek

Petr Mladek píše v Pá 27. 07. 2012 v 09:48 +0200:

> Kohei Yoshida píše v Čt 26. 07. 2012 v 21:06 -0400:
> > On 07/26/2012 06:20 PM, Markus Mohrhard wrote:
> > > Hey,
> > >
> > > [1] fixes the problem that calc does not import manual row heights in
> > > 3-6. We need to mark the rows as manual row height in the row flags to
> > > prevent overriding them with automatic row height calculation. You
> > > won't see this problem in master because we are not updating the row
> > > heights there at the moment.
> > >
> > > IMHO this is a fix for 3-6-0 because it is a quite serious issue.
> >
> > I agree. Pushed to the 3-6 branch with my sign-off.
>
> +1 One more approval needed for 3-6-0.

Thorsten did the third approval and pushed.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice