Document Foundation Mail Archive › LibreOffice › Dev

[REVIEW-3-6 3-6-2] fdo#55059, use correct cell for broadcasting

Classic

List

Threaded

4 messages Options

Markus Mohrhard

[REVIEW-3-6 3-6-2] fdo#55059, use correct cell for broadcasting

Hey,

[1] fixes another problem with broadcasters in the
ScColumn::DeleteRange method. If the broadcaster is transfered to the
temporary broadcaster cell this cell needs to be used to inform all
listeners that the cell has been deleted.

Regards,
Markus

[1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fa50ac35b6a56ae9628b0310cbf0eb7b4634736
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Kohei Yoshida

Re: [PUSHED 3-6][REVIEW 3-6-2 1/3] fdo#55059, use correct cell for broadcasting

On 09/19/2012 12:32 PM, Markus Mohrhard wrote:
> Hey,
>
> [1] fixes another problem with broadcasters in the
> ScColumn::DeleteRange method. If the broadcaster is transfered to the
> temporary broadcaster cell this cell needs to be used to inform all
> listeners that the cell has been deleted.

> [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=3fa50ac35b6a56ae9628b0310cbf0eb7b4634736

Looks good to me. Pushed to 3-6 with my sign off.

Two more needed for 3-6-2.

Kohei

--
Kohei Yoshida, LibreOffice hacker, Calc
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Miklos Vajna-2

Re: [PUSHED 3-6][REVIEW 3-6-2 2/3] fdo#55059, use correct cell for broadcasting

On Wed, Sep 19, 2012 at 01:22:54PM -0400, Kohei Yoshida <[hidden email]> wrote:
> Looks good to me. Pushed to 3-6 with my sign off.
>
> Two more needed for 3-6-2.

Looks reasonable to me.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Michael Meeks-2

Re: [PUSHED 3-6][REVIEW 3-6-2 2/3] fdo#55059, use correct cell for broadcasting

On Thu, 2012-09-20 at 12:24 +0200, Miklos Vajna wrote:
> On Wed, Sep 19, 2012 at 01:22:54PM -0400, Kohei Yoshida <[hidden email]> wrote:
> > Looks good to me. Pushed to 3-6 with my sign off.
> >
> > Two more needed for 3-6-2.

> Looks reasonable to me.

And me - thanks ! :-)

Michael.

--
[hidden email] <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice