[REVIEW-3-6 3-6-2] several patches for bugs in conditional formats/ ScRangeList
I have several patches that are needed to fix bugs in conditional
formats. One of them is a MAB/regression with several duplicates.
They apply cleanly on 3-6 and you may squash them into one large
commit but it makes reviewing them even more complicated. I did not do
that yet because it makes reviewing even more difficult. They allow to
update ScRangeLists correctly when the cells are moved or deleted.
There is one small problem with updating moving only parts of one of
the ScRange entries but this will require more concept work to find
all corner cases and to implement this. These cases are not that
important and these patches here are already an improvement in this
Nearly all of these patches are only changing ScRangeList and not
directly the conditional format code. I have some unit tests for
ScRangeList::UpdateReference and ScRangeList::DeleteArea in
into a single commit. All these commits are from Markus, and I have
signed-off on this, on the condition that we also backport my own change
on top of it to fix several issues that I discovered and fixed during my
The attached 0001 patch is Markus' patch, and the 0002 patch is mine on
top of it. Mine is basically a backport of
I also agree with Kohei that after we found these problems it is
better to push this only to 3-6 and I will send an ugly fix for the
crash that will just open one of the other fixed bugs but will prevent
the crash in 3.6.2.
And just for the record: Kohei's changes to my original patch look
good, I'm not sure if I can give my sign-off on them.