Document Foundation Mail Archive › LibreOffice › Dev

[REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Classic

List

Threaded

10 messages Options

Eike Rathke-2

[REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Hi,

Please review (date acceptance patterns, xml locale data changes only)
and cherry-pick to 3-6 and if possible, in case we'll do 3.6.0.4rc,
3-6-0

http://cgit.freedesktop.org/libreoffice/core/commit/?id=7828847618b58ff2009b5ce55416a8b2e5dcf55a
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae660e9efa4994bbfafa6de46b4b18aef2f1bb49
http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc52902eb218095652bf2921d5acfb9d0c863ac9
http://cgit.freedesktop.org/libreoffice/core/commit/?id=05035c894644f700fdc972b51dbd918f7530b2d5

that enable abbreviated date input for locales that use '/' date
separator, which, contrary to '.' and '-', are uncontroversial, see
https://bugs.freedesktop.org/show_bug.cgi?id=52240

Thanks
Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment

David Tardon

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Hi,

On Wed, Jul 25, 2012 at 05:55:55PM +0200, Eike Rathke wrote:
> Hi,
>
> Please review (date acceptance patterns, xml locale data changes only)
> and cherry-pick to 3-6 and if possible, in case we'll do 3.6.0.4rc,
> 3-6-0
>
> that enable abbreviated date input for locales that use '/' date
> separator, which, contrary to '.' and '-', are uncontroversial, see
> https://bugs.freedesktop.org/show_bug.cgi?id=52240

Hm, are they? What if I want to insert a fraction? Or am I missing
something (very probable)?

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Miklos Vajna-2

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

In reply to this post by Eike Rathke-2

On Wed, Jul 25, 2012 at 05:55:55PM +0200, Eike Rathke <[hidden email]> wrote:
> Please review (date acceptance patterns, xml locale data changes only)
> and cherry-pick to 3-6 and if possible, in case we'll do 3.6.0.4rc,
> 3-6-0
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=7828847618b58ff2009b5ce55416a8b2e5dcf55a
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=ae660e9efa4994bbfafa6de46b4b18aef2f1bb49
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc52902eb218095652bf2921d5acfb9d0c863ac9
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=05035c894644f700fdc972b51dbd918f7530b2d5

Pushed to -3-6.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Miklos Vajna-2

Re: [PUSHED 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Forgot to update subject.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Eike Rathke-2

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

In reply to this post by David Tardon

Hi David,

On Thursday, 2012-07-26 09:52:14 +0200, David Tardon wrote:

> > that enable abbreviated date input for locales that use '/' date
> > separator, which, contrary to '.' and '-', are uncontroversial
>
> Hm, are they? What if I want to insert a fraction? Or am I missing
> something (very probable)?

For fraction input you need an integer part as well,
so "1 2/3" or "0 23/42".

Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment

David Tardon

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Hi,

On Thu, Jul 26, 2012 at 12:23:49PM +0200, Eike Rathke wrote:

> Hi David,
>
> On Thursday, 2012-07-26 09:52:14 +0200, David Tardon wrote:
>
> > > that enable abbreviated date input for locales that use '/' date
> > > separator, which, contrary to '.' and '-', are uncontroversial
> >
> > Hm, are they? What if I want to insert a fraction? Or am I missing
> > something (very probable)?
>
> For fraction input you need an integer part as well,
> so "1 2/3" or "0 23/42".

Thanks for clarification. Since there are rumors of rc4, you have my +1
for 3-6-0.

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Petr Mladek

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

In reply to this post by Eike Rathke-2

Eike Rathke píše v Čt 26. 07. 2012 v 12:23 +0200:

I am not sure if this is intuitive, so it is slightly controversal as
well => we should not risk it for rc4.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Eike Rathke-2

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Hi Petr,

On Friday, 2012-07-27 11:21:43 +0200, Petr Mladek wrote:

> Eike Rathke píše v Čt 26. 07. 2012 v 12:23 +0200:
> > On Thursday, 2012-07-26 09:52:14 +0200, David Tardon wrote:
> > > > that enable abbreviated date input for locales that use '/' date
> > > > separator, which, contrary to '.' and '-', are uncontroversial
> > >
> > > Hm, are they? What if I want to insert a fraction? Or am I missing
> > > something (very probable)?
> >
> > For fraction input you need an integer part as well,
> > so "1 2/3" or "0 23/42".
>
> I am not sure if this is intuitive, so it is slightly controversal as
> well => we should not risk it for rc4.

Hum? The fraction input did not change, that was always the case. An
input of "23/42" never yielded a numeric value. The change enables
abbreviated (only month and day, e.g. 27/7) date input for those locales
again, where currently one has to enter a complete date, e.g. 27/7/2012

Eike

--
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

attachment0 (205 bytes) Download Attachment

Jan Holesovsky

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

Hi Eike,

On 2012-07-27 at 11:29 +0200, Eike Rathke wrote:

> > I am not sure if this is intuitive, so it is slightly controversal as
> > well => we should not risk it for rc4.
>
> Hum? The fraction input did not change, that was always the case. An
> input of "23/42" never yielded a numeric value. The change enables
> abbreviated (only month and day, e.g. 27/7) date input for those locales
> again, where currently one has to enter a complete date, e.g. 27/7/2012

The question is - is this that serious that it cannot wait until 3.6.1?
If you can get enough approvals for 3.6.0 still, nobody will block it I
guess :-), but I for one would really like to limit the amount of things
that go to rc4 to bare minimum.

All the best,
Kendy

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Petr Mladek

Re: [REVIEW 3-6][REVIEW 3-6-0] fdo#52240 add uncontroversial date acceptance patterns

In reply to this post by Eike Rathke-2

Eike Rathke píše v Pá 27. 07. 2012 v 11:29 +0200:

> Hi Petr,
>
> On Friday, 2012-07-27 11:21:43 +0200, Petr Mladek wrote:
>
> > Eike Rathke píše v Čt 26. 07. 2012 v 12:23 +0200:
> > > On Thursday, 2012-07-26 09:52:14 +0200, David Tardon wrote:
> > > > > that enable abbreviated date input for locales that use '/' date
> > > > > separator, which, contrary to '.' and '-', are uncontroversial
> > > >
> > > > Hm, are they? What if I want to insert a fraction? Or am I missing
> > > > something (very probable)?
> > >
> > > For fraction input you need an integer part as well,
> > > so "1 2/3" or "0 23/42".
> >
> > I am not sure if this is intuitive, so it is slightly controversal as
> > well => we should not risk it for rc4.
>
> Hum? The fraction input did not change, that was always the case. An
> input of "23/42" never yielded a numeric value. The change enables
> abbreviated (only month and day, e.g. 27/7) date input for those locales
> again, where currently one has to enter a complete date, e.g. 27/7/2012

OK, you convinced me that the change is fine. Well, lets leave it for
3.6.1. It affects many files and many localizations. I believe that you
did it carefully but let's get only critical or super-trivial changes
for the non-planed rc4.

Best Regards,
Petr

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice