Quantcast

Re: [Libreoffice-commits] .: 3 commits - basctl/source chart2/source cppcanvas/source cui/source dbaccess/source editeng/source filter/source framework/source package/source reportdesign/source scp2/source svtools/source svx/source toolkit/inc toolkit/source

classic Classic list List threaded Threaded
2 messages Options
Lubos Lunak Lubos Lunak
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [Libreoffice-commits] .: 3 commits - basctl/source chart2/source cppcanvas/source cui/source dbaccess/source editeng/source filter/source framework/source package/source reportdesign/source scp2/source svtools/source svx/source toolkit/inc toolkit/source

On Wednesday 18 of July 2012, Stephan Bergmann wrote:

> diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx
> index 24a0b87..270b956 100644
> --- a/svx/source/form/filtnav.cxx
> +++ b/svx/source/form/filtnav.cxx
> @@ -249,15 +249,15 @@ TYPEINIT1( FmFilterHint, SfxHint );
>  //========================================================================
>  class FmFilterInsertedHint : public FmFilterHint
>  {
> -    sal_Int32 m_nPos;   // Position relative to the parent of the data
> +    sal_uLong m_nPos;   // Position relative to the parent of the data

 Isn't sal_uLong deprecated?

--
 Lubos Lunak
 [hidden email]
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Stephan Bergmann-2 Stephan Bergmann-2
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: [Libreoffice-commits] .: 3 commits - basctl/source chart2/source cppcanvas/source cui/source dbaccess/source editeng/source filter/source framework/source package/source reportdesign/source scp2/source svtools/source svx/source toolkit/inc toolkit/source

On 07/18/2012 02:56 PM, Lubos Lunak wrote:

> On Wednesday 18 of July 2012, Stephan Bergmann wrote:
>> diff --git a/svx/source/form/filtnav.cxx b/svx/source/form/filtnav.cxx
>> index 24a0b87..270b956 100644
>> --- a/svx/source/form/filtnav.cxx
>> +++ b/svx/source/form/filtnav.cxx
>> @@ -249,15 +249,15 @@ TYPEINIT1( FmFilterHint, SfxHint );
>>   //========================================================================
>>   class FmFilterInsertedHint : public FmFilterHint
>>   {
>> -    sal_Int32 m_nPos;   // Position relative to the parent of the data
>> +    sal_uLong m_nPos;   // Position relative to the parent of the data
>
>   Isn't sal_uLong deprecated?

But here, the code at large still uses sal_uLong and only some small
part had been using sal_Int32 instead.  That didn't fit together.

Stephan
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...