Quantcast

Re: [Libreoffice-commits] core.git: basegfx/source bin/symbolstore.py chart2/source connectivity/source editeng/source forms/source fpicker/source include/editeng include/svx include/uno odk/examples schema/odf1.0 shell/source stoc/source sw/source sysui/desktop xmloff/dtd xmlsecurity/inc

classic Classic list List threaded Threaded
3 messages Options
Miklos Vajna-3 Miklos Vajna-3
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Libreoffice-commits] core.git: basegfx/source bin/symbolstore.py chart2/source connectivity/source editeng/source forms/source fpicker/source include/editeng include/svx include/uno odk/examples schema/odf1.0 shell/source stoc/source sw/source sysui/desktop xmloff/dtd xmlsecurity/inc

Hi,

On Sun, Mar 19, 2017 at 05:49:39AM +0000, Andrea Gelmini <[hidden email]> wrote:

> diff --git a/schema/odf1.0/OpenDocument-schema-v1.0-os.rng b/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> index 8f21e4caf46a..00eb7ebd578e 100644
> --- a/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> +++ b/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> @@ -16412,7 +16412,7 @@
>          <attribute name="dr3d:texture-kind">
>              <choice>
>                  <value>luminance</value>
> -                <value>intesity</value>
> +                <value>intensity</value>
>                  <value>color</value>
>              </choice>
>          </attribute>
Please don't do this -- you change what is assumed to be a valid ODF 1.0
with this change!

See the commit message of 70152506d968f407fad3a1cb6959c67f99bd59ce.
51d996354f11048d7759cd7e206a2383421c2c81's schema/ part is less
problematic, as it's at least a comment, but still: best to not touch
schema/ at all.

Regards,

Miklos

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (188 bytes) Download Attachment
Miklos Vajna-4 Miklos Vajna-4
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Libreoffice-commits] core.git: basegfx/source bin/symbolstore.py chart2/source connectivity/source editeng/source forms/source fpicker/source include/editeng include/svx include/uno odk/examples schema/odf1.0 shell/source stoc/source sw/source sysui/desktop xmloff/dtd xmlsecurity/inc

Hi,

On Sun, Mar 19, 2017 at 05:49:39AM +0000, Andrea Gelmini <[hidden email]> wrote:

> diff --git a/schema/odf1.0/OpenDocument-schema-v1.0-os.rng b/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> index 8f21e4caf46a..00eb7ebd578e 100644
> --- a/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> +++ b/schema/odf1.0/OpenDocument-schema-v1.0-os.rng
> @@ -16412,7 +16412,7 @@
>          <attribute name="dr3d:texture-kind">
>              <choice>
>                  <value>luminance</value>
> -                <value>intesity</value>
> +                <value>intensity</value>
>                  <value>color</value>
>              </choice>
>          </attribute>

Please don't do this -- you change what is assumed to be a valid ODF 1.0
with this change!

See the commit message of 70152506d968f407fad3a1cb6959c67f99bd59ce.
51d996354f11048d7759cd7e206a2383421c2c81's schema/ part is less
problematic, as it's at least a comment, but still: best to not touch
schema/ at all.

Regards,

Miklos
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Andrea Gelmini Andrea Gelmini
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [Libreoffice-commits] core.git: basegfx/source bin/symbolstore.py chart2/source connectivity/source editeng/source forms/source fpicker/source include/editeng include/svx include/uno odk/examples schema/odf1.0 shell/source stoc/source sw/source sysui/desktop xmloff/dtd xmlsecurity/inc

In reply to this post by Miklos Vajna-3
2017-03-20 9:24 GMT+01:00 Miklos Vajna <[hidden email]>:
> Please don't do this -- you change what is assumed to be a valid ODF 1.0
> with this change!

Got it!

Thanks a lot,
Andrea
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...