Re: [Libreoffice-commits] core.git: solenv/gbuild

classic Classic list List threaded Threaded
5 messages Options
Thorsten Behrens-6 Thorsten Behrens-6
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: solenv/gbuild

jan Iversen wrote:

> commit 25e395c7e07015fb5c9b88978093889315d32f3c
> Author: jan Iversen <[hidden email]>
> Date:   Sat Sep 9 20:59:52 2017 +0200
>
>     iOS, update gbuild platform
>
>     IOS => iOS
>     added iOS_ARM64
>     added iOS_X86_64 and iOS_I386 for simulator
>
Hi Jan,

hmm - that's essentially now four copies of pretty much the same file?
Could you look into perhaps sharing common stuff like the linux
platform makefiles do it, via include $(GBUILDDIR)/platform/ios.mk or
something?

Cheers,

-- Thorsten

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice

signature.asc (968 bytes) Download Attachment
jani libreoffice jani libreoffice
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: solenv/gbuild

Hi Thorsten.

done, e216f72228da2e55573a96abf267ca6de1cebb57

rgds
jan i

_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-2 Michael Stahl-2
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: solenv/gbuild

In reply to this post by Thorsten Behrens-6
On 09.09.2017 22:52, Thorsten Behrens wrote:
> jan Iversen wrote:
>> commit 25e395c7e07015fb5c9b88978093889315d32f3c
>> Author: jan Iversen <[hidden email]>
>> Date:   Sat Sep 9 20:59:52 2017 +0200
>>
>>     iOS, update gbuild platform
>>
>>     IOS => iOS

this is a rather inconsistent change: the files are now called "iOS-*"
while the $(OS) variable is still "IOS", so this only works on
case-insensitive file systems; cf. solenv/gbuild/gbuild.mk:

> # Include platform/cpu/compiler specific config/definitions
> include $(GBUILDDIR)/platform/$(OS)_$(CPUNAME)_$(COM).mk

do you want to change the value of $(OS) too?
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Tor Lillqvist-2 Tor Lillqvist-2
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: solenv/gbuild


do you want to change the value of $(OS) too?


Which would make it inconsistent with all the other $(OS) values, which all are UPPER-CASE ONLY, no?

--tml
 


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
jani libreoffice jani libreoffice
Reply | Threaded
Open this post in threaded view
|

Re: [Libreoffice-commits] core.git: solenv/gbuild

It builds on macosx which is the only source for iOS so I do no really see a need to change the file names.

I followed the all caps standard for OS which makes sense to me.

rgds
jan i

Sent from my iPad

On 11 Sep 2017, at 12:22, Tor Lillqvist <[hidden email]> wrote:


do you want to change the value of $(OS) too?


Which would make it inconsistent with all the other $(OS) values, which all are UPPER-CASE ONLY, no?

--tml
 


_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice