Temporary files written to predetermined location during build

classic Classic list List threaded Threaded
11 messages Options
Paul Menzel-2 Paul Menzel-2
Reply | Threaded
Open this post in threaded view
|

Temporary files written to predetermined location during build

Dear LibreOffice folks,


I was asked in #111553 (Temporary files written to predetermined
location) [1] to contact the mailing list.

> Building LibreOffice 5.4.0.3 with one user, and then building it with another
> user shows that it tries to write to the same paths in the temporary directory,
> which of course fails.
>
> ```
> […]
> ------------------------------------
> ... languages de_en-US ...
> ... analyzing files ...
> ... analyzing files with flag FILELIST ...
> filelist
> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/build/workdir/Package/xmlsec.filelist
> is empty
> ... analyzing files with flag SCPZIP_REPLACE ...
> ... analyzing all directories for this product ...
> ... analyzing links ...
> ... analyzing unix links ...
> ... creating profiles ...
> fatal: Not a git repository (or any parent up to mount point /dev)
> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
> ERROR: Failure in installer.pm
> ERROR: ERROR: Cannot open file
> /tmp/LibreOffice//profiles/de_en-US/gid_Brand_Profile_Bootstrap_Ini/bootstraprc
> for writing at
> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/source/solenv/bin/modules/installer/files.pm
> line 85.
>
> ... cleaning the output tree ...
> ... removing directory /tmp/ooopackaging6idOna/i_647771502279265 ...
>
> *************************************************
> ERROR: Cannot write log file
> /tmp/LibreOffice//logging/de_en-US/log_540_de_en-US.log, Permission denied
> *************************************************
> Failed to install: No such file or directory at
> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/source/solenv/bin/ooinstall
> line 92.
> Makefile:311: recipe for target 'install' failed
> make: *** [install] Error 2
> ```
>
> At least the two directories below contain conflicting files.
>
> 1.  `/tmp/LibreOffice/profiles/de_en-US/`
> 2.  `/tmp/LibreOffice/logging/de_en-US/`


Kind regards,

Paul


[1] https://bugs.documentfoundation.org/show_bug.cgi?id=111553
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Stahl-2 Michael Stahl-2
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

On 09.08.2017 14:27, Paul Menzel wrote:

>> Building LibreOffice 5.4.0.3 with one user, and then building it with another
>> user shows that it tries to write to the same paths in the temporary directory,
>> which of course fails.
>>
>> ```
>> […]
>> ------------------------------------
>> ... languages de_en-US ...
>> ... analyzing files ...
>> ... analyzing files with flag FILELIST ...
>> filelist
>> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/build/workdir/Package/xmlsec.filelist
>> is empty
>> ... analyzing files with flag SCPZIP_REPLACE ...
>> ... analyzing all directories for this product ...
>> ... analyzing links ...
>> ... analyzing unix links ...
>> ... creating profiles ...
>> fatal: Not a git repository (or any parent up to mount point /dev)
>> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
>> ERROR: Failure in installer.pm
>> ERROR: ERROR: Cannot open file
>> /tmp/LibreOffice//profiles/de_en-US/gid_Brand_Profile_Bootstrap_Ini/bootstraprc
>> for writing at
>> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/source/solenv/bin/modules/installer/files.pm
>> line 85.

that definitely looks like a bug, it should create that inside some
random subdirectory...

>> ... cleaning the output tree ...
>> ... removing directory /tmp/ooopackaging6idOna/i_647771502279265 ...

... like ^ this one ...

the bug must be somewhere in solenv/bin/modules/...

although i don't think i've ever seen a failure like this, and i build
multiple release branches concurrently every day... maybe it happens
only if you have translations enabled or something like that?
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jean-Baptiste Faure-3 Jean-Baptiste Faure-3
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

Hi,

Le 09/08/2017 à 14:35, Michael Stahl a écrit :

> On 09.08.2017 14:27, Paul Menzel wrote:
>>> Building LibreOffice 5.4.0.3 with one user, and then building it with another
>>> user shows that it tries to write to the same paths in the temporary directory,
>>> which of course fails[...]
>
> the bug must be somewhere in solenv/bin/modules/...
>
> although i don't think i've ever seen a failure like this, and i build
> multiple release branches concurrently every day... maybe it happens
> only if you have translations enabled or something like that?

I build LO 5.4 and master every day, both with translations enabled and
I never had a failure like that.

What is surprising me is that : "Building LibreOffice 5.4.0.3 with one
user, and then building it with another user...". Does that mean that
the local repository is shared between several users ?

Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

Hi,

On Wed, Aug 09, 2017 at 08:23:42PM +0200, Jean-Baptiste Faure wrote:
> What is surprising me is that : "Building LibreOffice 5.4.0.3 with one user,
> and then building it with another user...". Does that mean that the local
> repository is shared between several users ?

How does the local repository matter is this is about /tmp? /tmp of course
is shared between users.

Regards,

Rene
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Paul Menzel-2 Paul Menzel-2
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

Dear Jean-Baptiste, dear Rene,


On 08/10/17 09:13, Rene Engelhard wrote:

> On Wed, Aug 09, 2017 at 08:23:42PM +0200, Jean-Baptiste Faure wrote:
>> What is surprising me is that : "Building LibreOffice 5.4.0.3 with one user,
>> and then building it with another user...". Does that mean that the local
>> repository is shared between several users ?
>
> How does the local repository matter is this is about /tmp? /tmp of course
> is shared between users.

Indeed, the machine is used by several users. (And for some reason they
all build LibreOffice. ;-))


Kind regards,

Paul
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jean-Baptiste Faure-3 Jean-Baptiste Faure-3
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

In reply to this post by Rene Engelhard
Le 10/08/2017 à 09:13, Rene Engelhard a écrit :
> Hi,
>
> On Wed, Aug 09, 2017 at 08:23:42PM +0200, Jean-Baptiste Faure wrote:
>> What is surprising me is that : "Building LibreOffice 5.4.0.3 with one user,
>> and then building it with another user...". Does that mean that the local
>> repository is shared between several users ?
>
> How does the local repository matter is this is about /tmp? /tmp of course
> is shared between users.

I don't know but I am trying to understand how users are working on this
machine. And I see this error message :
"fatal: Not a git repository (or any parent up to mount point /dev) "

Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Jean-Baptiste Faure-3 Jean-Baptiste Faure-3
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

In reply to this post by Paul Menzel-2
Le 10/08/2017 à 10:07, Paul Menzel a écrit :
> [...]
> Indeed, the machine is used by several users. (And for some reason they
> all build LibreOffice. ;-))

I was not talking about the machine itself but about the local git
repository in which the LibreOffice source code has been cloned.

Best regards.
JBF

--
Seuls des formats ouverts peuvent assurer la pérennité de vos documents.
Disclaimer: my Internet Provider being located in France, each of our
exchanges over Internet will be scanned by French spying services.
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Paul Menzel-2 Paul Menzel-2
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

In reply to this post by Jean-Baptiste Faure-3
Dear Jean-Baptiste,


On 08/10/17 10:47, Jean-Baptiste Faure wrote:
> Le 10/08/2017 à 09:13, Rene Engelhard a écrit :

>> On Wed, Aug 09, 2017 at 08:23:42PM +0200, Jean-Baptiste Faure wrote:
>>> What is surprising me is that : "Building LibreOffice 5.4.0.3 with
>>> one user,
>>> and then building it with another user...". Does that mean that the
>>> local
>>> repository is shared between several users ?
>>
>> How does the local repository matter is this is about /tmp? /tmp of
>> course is shared between users.
>
> I don't know but I am trying to understand how users are working on this
> machine. And I see this error message :
> "fatal: Not a git repository (or any parent up to mount point /dev) "

The tar archive [1] is used.


Kind regards,

Paul


[1]
https://download.documentfoundation.org/libreoffice/src/5.4.0/libreoffice-5.4.0.3.tar.xz
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

In reply to this post by Michael Stahl-2
[ revisiting this thread since after all those unrelated replies it diesd. ]

Hi

On Wed, Aug 09, 2017 at 02:35:40PM +0200, Michael Stahl wrote:

> On 09.08.2017 14:27, Paul Menzel wrote:
> >> Building LibreOffice 5.4.0.3 with one user, and then building it with another
> >> user shows that it tries to write to the same paths in the temporary directory,
> >> which of course fails.
> >>
> >> ```
> >> […]
> >> ------------------------------------
> >> ... languages de_en-US ...
> >> ... analyzing files ...
> >> ... analyzing files with flag FILELIST ...
> >> filelist
> >> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/build/workdir/Package/xmlsec.filelist
> >> is empty
> >> ... analyzing files with flag SCPZIP_REPLACE ...
> >> ... analyzing all directories for this product ...
> >> ... analyzing links ...
> >> ... analyzing unix links ...
> >> ... creating profiles ...
> >> fatal: Not a git repository (or any parent up to mount point /dev)
> >> Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
> >> ERROR: Failure in installer.pm
> >> ERROR: ERROR: Cannot open file
> >> /tmp/LibreOffice//profiles/de_en-US/gid_Brand_Profile_Bootstrap_Ini/bootstraprc
> >> for writing at
> >> /dev/shm/bee-root/libreoffice/libreoffice-5.4.0.3-0/source/solenv/bin/modules/installer/files.pm
> >> line 85.
>
> that definitely looks like a bug, it should create that inside some
> random subdirectory...

Yes, especially as /tmp/<something predictable> is (also) a security-related bug
(possible symlink attack)..

See also http://bugs.debian.org/875415 which I just received...

Regards,

Rene
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Wols Lists Wols Lists
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

On 11/09/17 10:07, Rene Engelhard wrote:
>> that definitely looks like a bug, it should create that inside some
>> random subdirectory..

> Yes, especially as/tmp/<something predictable> is (also) a security-related bug
> (possible symlink attack)..
>
> See alsohttp://bugs.debian.org/875415  which I just received...

My experience of /tmp is that most things seem to create and write to
/tmp/username or similar - it's odd to write straight into /tmp.

And that I guess is what's behind the original bug reported - the first
user obviously created a directory with permissions set for him, then
the second user came along, tried to use the same directory, and without
write permission the second build fell over. (Obviously, whether that
happens depends on how fast the reaper reaps the contents of /tmp.)

Cheers,
Wol
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice
Rene Engelhard Rene Engelhard
Reply | Threaded
Open this post in threaded view
|

Re: Temporary files written to predetermined location during build

Hi,

On Wed, Sep 13, 2017 at 06:39:45PM +0100, Anthony Youngman wrote:
> And that I guess is what's behind the original bug reported - the first user
> obviously created a directory with permissions set for him, then the second
> user came along, tried to use the same directory, and without write
> permission the second build fell over. (Obviously, whether that happens

Yes, of course. But apparently people didn't care and degraded that thread
into something source-location'ish...

> depends on how fast the reaper reaps the contents of /tmp.)

a.k.a "reboot".

Regards,

Rene
_______________________________________________
LibreOffice mailing list
[hidden email]
https://lists.freedesktop.org/mailman/listinfo/libreoffice