and strangely replaced the similar code in SfxFrame::Create with the
same "fix" used in commit 2 (might it be a mis-merge?).
My guess is that the "if" in the code under consideration can be removed
since such code was untouched for so long but I have no idea about what
this code is menat to do. Does anybody have a clue on what this code is
supposed to do and on how to proceed?
Re: Unuseful SfxObjectFactory::GetFactoryURL() in SfxViewFrame::LoadViewIntoFrame_Impl, any clue?
On 2017-03-20 14:44, Caolán McNamara wrote:
> On Fri, 2017-03-17 at 17:39 +0100, Matteo Casalin wrote:
>> 3. Commit
>> https://cgit.freedesktop.org/libreoffice/core/commit/?id=a8f1ad65612c >> 0e54969cabc541b183062ae3d905
>> My guess is that the "if" in the code under consideration can be
> Yeah, its clearly meaningless so might as well remove it. No idea what
> the original intent there was, but its all quite a long time ago now so
> safest is to just remove the code that does nothing.
Great, I will remove that lines.
Thanks for the feedback!