feature/gbuild_ure needs testing

Hi all,

now that 3.6.0 is sucessfully out, I have started pushing gbuild
conversion forward again. The latest result of my effort is on branch
feature/gbuild_ure and you really do want to test that it works on your
platform :-) What is there:

1/ Module bridges has been converted to gbuild. This module is _crucial_
   for UNO. Have I already said that you want to test the branch? The
   absolute minimum to check that C++ bridge still works is to run

   make testtools.all

2/ Module cli_ure has been converted to gbuild. Actually I have created
   some machinery for building CLI stuff in gbuild, because it seemed to
   make more sense than copy-pasting (nearly) the same code several
   times. This only builds on windows. I do expect some problems, because
   I only smoketested the code (replacing all commands by touch $@).

3/ 21 modules have been added to tail_build. I hope that I have found
   and fixed all incomplete dependencies, but it is possible that some
   additional ones arise on different platforms/configurations.

If you find a problem, yell at me or fix it :-)

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

on mac I get:

[ build LNK ] CppunitTest/libtest_svl_lngmisc.dylib

> error: no simple registry service!
> dying...
make[2]: *** [/Volumes/Raid0/rel/workdir/unxmacxi.pro/CustomTarget/testtools/uno_test.done]
Error 1
make[2]: *** Waiting for unfinished jobs....
/bin/sh: line 1: 78722 Abort trap
DYLD_LIBRARY_PATH="$O/lib" DBGSV_ERROR_OUT=shell
STAR_RESOURCEPATH=$O/bin/ $O/bin/cppunit/cppunittester
$W/LinkTarget/CppunitTest/libtest_sot_test_sot.dylib --headless
"-env:UNO_TYPES=file://$O/bin/offapi.rdb file://$O/bin/udkapi.rdb"
"-env:UNO_SERVICES=file://$O/xml/ure/services.rdb"
-env:URE_INTERNAL_LIB_DIR=file://$O/lib -env:LO_LIB_DIR=file://$O/lib
--protector unoexceptionprotector.dylib unoexceptionprotector
--protector unobootstrapprotector.dylib unobootstrapprotector >
$W/CppunitTest/sot_test_sot.test.log 2>&1
terminate called after throwing an instance of
'com::sun::star::loader::CannotActivateFactoryException'

Norbert
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

on windows:

I needed:
$ git diff
diff --git a/solenv/gbuild/CliLibrary.mk b/solenv/gbuild/CliLibrary.mk
index 36352b7..d4f6841 100644
--- a/solenv/gbuild/CliLibrary.mk
+++ b/solenv/gbuild/CliLibrary.mk
@@ -20,17 +20,17 @@ gb_CliLibraryTarget_CSCFLAGS_DEBUG := \
        -define:DEBUG \
        -define:TRACE \

-define gb_CliLibraryTarget__get_csflags
+
 ifeq ($(strip $(debug)),)
 ifeq ($(strip $(PRODUCT)),)
-$(gb_CliLibraryTarget_CSCFLAGS) $(gb_CliLibraryTarget_CSCFLAGS_DEBUG)
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS)
$(gb_CliLibraryTarget_CSCFLAGS_D
 else
-$(gb_CliLibraryTarget_CSCFLAGS) -o
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS) -o
 endif
 else
-$(gb_CliLibraryTarget_CSCFLAGS) $(gb_CliLibraryTarget_CSCFLAGS_DEBUG) -debug+
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS)
$(gb_CliLibraryTarget_CSCFLAGS_D
 endif
-endef
+

 gb_CliLibraryTarget__get_source = $(SRCDIR)/$(1).cs
 gb_CliLibraryTarget__get_generated_source = $(WORKDIR)/$(1).cs

to work around
S=C:/lo/core && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  csc ifeq (,)
/bin/sh: -c: line 0: syntax error near unexpected token `('
/bin/sh: -c: line 0: `S=C:/lo/core && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  csc ifeq (,)'

re-running it clean now...

Norbert

PS: both mac and windows are built with tinderbox setting so
--disable-dependency-tracking   I will try to shake out the potential
dep issue later...
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

arghh the previous diff got mangled.. here is a corrected version:

--- a/solenv/gbuild/CliLibrary.mk
+++ b/solenv/gbuild/CliLibrary.mk
@@ -20,17 +20,17 @@ gb_CliLibraryTarget_CSCFLAGS_DEBUG := \
        -define:DEBUG \
        -define:TRACE \

-define gb_CliLibraryTarget__get_csflags
+
 ifeq ($(strip $(debug)),)
 ifeq ($(strip $(PRODUCT)),)
-$(gb_CliLibraryTarget_CSCFLAGS) $(gb_CliLibraryTarget_CSCFLAGS_DEBUG)
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS)
$(gb_CliLibraryTarget_CSCFLAGS_DEBUG)
 else
-$(gb_CliLibraryTarget_CSCFLAGS) -o
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS) -o
 endif
 else
-$(gb_CliLibraryTarget_CSCFLAGS) $(gb_CliLibraryTarget_CSCFLAGS_DEBUG) -debug+
+gb_CliLibraryTarget__get_csflags=$(gb_CliLibraryTarget_CSCFLAGS)
$(gb_CliLibraryTarget_CSCFLAGS_DEBUG) -debug+
 endif
-endef
+

 gb_CliLibraryTarget__get_source = $(SRCDIR)/$(1).cs
 gb_CliLibraryTarget__get_generated_source = $(WORKDIR)/$(1).cs
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

ok so now windows fail with

C:/lo/core/solenv/gbuild/Package.mk:44: *** gb_Deliver_deliver: file
does not exist in solver, and cannot be delivered:
C:/lo/core/solver/wntmsci12.pro/bin/cliuno.snk.  Stop.
make[2]: *** Waiting for unfinished jobs....

the following seens to fix that:
diff --git a/cli_ure/Package_config.mk b/cli_ure/Package_config.mk
index 820f25e..175fd33 100644
--- a/cli_ure/Package_config.mk
+++ b/cli_ure/Package_config.mk
@@ -9,7 +9,7 @@

 $(eval $(call gb_Package_Package,cli_ure_cliuno,$(SRCDIR)/cli_ure/source))

-$(eval $(call gb_Package_add_files,bin,\
+$(eval $(call gb_Package_add_files,cli_ure_cliuno,bin,\
        climaker/climaker.exe.config \
        cliuno.snk \
 ))


and then I get
  ### call $(gb_Helper_abbreviate_dirs) -->
  ### arg 0 for call $(gb_Helper_abbreviate_dirs) is 'gb_Helper_abbreviate_dirs'
  ### arg 1 for call $(gb_Helper_abbreviate_dirs) is ' csc -noconfig
-warnaserror+ -o  -target:library
-out:C:/lo/core/workdir/wntmsci12.pro/CliLibraryTarget/cli_basetypes.dll
-reference:System.dll   C:/lo/core/cli_ure/source/basetypes/uno/Any.cs
C:/lo/core/cli_ure/source/basetypes/uno/BoundAttribute.cs
C:/lo/core/cli_ure/source/basetypes/uno/ExceptionAttribute.cs
C:/lo/core/cli_ure/source/basetypes/uno/OnewayAttribute.cs
C:/lo/core/cli_ure/source/basetypes/uno/ParameterizedTypeAttribute.cs
C:/lo/core/cli_ure/source/basetypes/uno/PolymorphicType.cs
C:/lo/core/cli_ure/source/basetypes/uno/TypeArgumentsAttribute.cs
C:/lo/core/cli_ure/source/basetypes/uno/TypeParametersAttribute.cs
C:/lo/core/workdir/wntmsci12.pro/CustomTarget/cli_ure/source/basetypes/assembly.cs
'
  ### arg 2 for call $(gb_Helper_abbreviate_dirs) is implicit
  ### arg 3 for call $(gb_Helper_abbreviate_dirs) is implicit
  ### arg 4 for call $(gb_Helper_abbreviate_dirs) is implicit
  ### arg 5 for call $(gb_Helper_abbreviate_dirs) is implicit
  ### call to $(gb_Helper_abbreviate_dirs) expended into
S=C:/lo/core && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  csc -noconfig -warnaserror+ -o
-target:library -out:$W/CliLibraryTarget/cli_basetypes.dll
-reference:System.dll   $S/cli_ure/source/basetypes/uno/Any.cs
$S/cli_ure/source/basetypes/uno/BoundAttribute.cs
$S/cli_ure/source/basetypes/uno/ExceptionAttribute.cs
$S/cli_ure/source/basetypes/uno/OnewayAttribute.cs
$S/cli_ure/source/basetypes/uno/ParameterizedTypeAttribute.cs
$S/cli_ure/source/basetypes/uno/PolymorphicType.cs
$S/cli_ure/source/basetypes/uno/TypeArgumentsAttribute.cs
$S/cli_ure/source/basetypes/uno/TypeParametersAttribute.cs
$W/CustomTarget/cli_ure/source/basetypes/assembly.cs
  ### call $(gb_Helper_abbreviate_dirs) <--
 ### call to $(gb_CliLibraryTarget__command) expended into

S=C:/lo/core && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  csc -noconfig -warnaserror+ -o
-target:library -out:$W/CliLibraryTarget/cli_basetypes.dll
-reference:System.dll   $S/cli_ure/source/basetypes/uno/Any.cs
$S/cli_ure/source/basetypes/uno/BoundAttribute.cs
$S/cli_ure/source/basetypes/uno/ExceptionAttribute.cs
$S/cli_ure/source/basetypes/uno/OnewayAttribute.cs
$S/cli_ure/source/basetypes/uno/ParameterizedTypeAttribute.cs
$S/cli_ure/source/basetypes/uno/PolymorphicType.cs
$S/cli_ure/source/basetypes/uno/TypeArgumentsAttribute.cs
$S/cli_ure/source/basetypes/uno/TypeParametersAttribute.cs
$W/CustomTarget/cli_ure/source/basetypes/assembly.cs
 ### call $(gb_CliLibraryTarget__command) <--
S=C:/lo/core && O=$S/solver/wntmsci12.pro &&
W=$S/workdir/wntmsci12.pro &&  csc -noconfig -warnaserror+ -o
-target:library -out:$W/CliLibraryTarget/cli_basetypes.dll
-reference:System.dll   $S/cli_ure/source/basetypes/uno/Any.cs
$S/cli_ure/source/basetypes/uno/BoundAttribute.cs
$S/cli_ure/source/basetypes/uno/ExceptionAttribute.cs
$S/cli_ure/source/basetypes/uno/OnewayAttribute.cs
$S/cli_ure/source/basetypes/uno/ParameterizedTypeAttribute.cs
$S/cli_ure/source/basetypes/uno/PolymorphicType.cs
$S/cli_ure/source/basetypes/uno/TypeArgumentsAttribute.cs
$S/cli_ure/source/basetypes/uno/TypeParametersAttribute.cs
$W/CustomTarget/cli_ure/source/basetypes/assembly.cs
Microsoft (R) Visual C# 2008 Compiler version 3.5.30729.5420
for Microsoft (R) .NET Framework version 3.5
Copyright (C) Microsoft Corporation. All rights reserved.

error CS1504: Source file 'c:\lo\core\cli_ure\Any.cs' could not be
opened ('The system cannot find the file specified. ')
error CS1504: Source file 'c:\lo\core\cli_ure\BoundAttribute.cs' could
not be opened ('The system cannot find the file specified. ')
error CS1504: Source file 'c:\lo\core\cli_ure\ExceptionAttribute.cs'
could not be opened ('The system cannot find the file specified. ')
error CS1504: Source file 'c:\lo\core\cli_ure\OnewayAttribute.cs'
could not be opened ('The system cannot find the file specified. ')
error CS1504: Source file
'c:\lo\core\cli_ure\ParameterizedTypeAttribute.cs' could not be opened
('The system cannot find the file specified. ')
error CS1504: Source file 'c:\lo\core\cli_ure\PolymorphicType.cs'
could not be opened ('The system cannot find the file specified. ')
error CS1504: Source file
'c:\lo\core\cli_ure\TypeArgumentsAttribute.cs' could not be opened
('The system cannot find the file specified. ')
error CS1504: Source file
'c:\lo\core\cli_ure\TypeParametersAttribute.cs' could not be opened
('The system cannot find the file specified. ')
error CS1504: Source file 'c:\lo\core\cli_ure\assembly.cs' could not
be opened ('The system cannot find the file specified. ')
make: *** [C:/lo/core/workdir/wntmsci12.pro/CliLibraryTarget/cli_basetypes.dll]
Error 1

which is stumping me....  no idea where that MS stuff get the argument
converted from what the command line says... i.e how
/source/basetypes/uno get stripped (provided I know nothing of MSJava,
nor do I care to learn, really)

Norbert

Norbert
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi David,

On 2 August 2012 12:00, David Tardon <[hidden email]> wrote:
> Hi all,
>
> now that 3.6.0 is sucessfully out, I have started pushing gbuild
> conversion forward again. The latest result of my effort is on branch
> feature/gbuild_ure

Nice, looks really good :-)

> 1/ Module bridges has been converted to gbuild. This module is _crucial_
>    for UNO. Have I already said that you want to test the branch? The
>    absolute minimum to check that C++ bridge still works is to run
>
>    make testtools.all

I need for both linux and windows to add proper version of
+    -env:URE_INTERNAL_LIB_DIR=file://$(OUTDIR)/lib \
into CustomTarget_uno_test.mk
No idea why and how it works in master, so I did not commit it.

Thanks,
Matus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

On Sat, Aug 04, 2012 at 02:16:42PM -0500, Norbert Thiebaud wrote:
This is embarassing...

That makes two of us, unfortunately... The command works with mcs
(mono's C# compiler), after changing -o to -optimize (-o is obsolete
synonym to -out in mcs).

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 2 August 2012 12:00, David Tardon <[hidden email]> wrote:
>    This only builds on windows. I do expect some problems, because
>    I only smoketested the code (replacing all commands by touch $@).

There were few problems ;-)
After http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/gbuild_ure&id=d8fc82680dd530ed201cfa0eb4491c093469e191
It is possible to build cli_ure but..

with make -k && make or similar because
the CliLibrary things are missing dependency on cliuno.snk, something
like f7f593dd299d11edbb85ba66b10ca1c47cf26ca4
I thought you will find a best place for that dep :-)

I've removed -warnaserror+ . It should not be bad ?

What's worse is that I made random symbol exported from
cli_cppuhelper_native library.
I tried to build it with dmake and find out what symbols should be
exported from there but found nothing.
So that library is proly useless ? Anyway, who cares, it's windows..
but with rules in gbuild in such cases you are missing .lib file and get error.
I've found out this some time ago when I was converting some windows module.
So, the exported symbol is workaround for this.

Best,
Matus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

On Mon, Aug 06, 2012 at 11:41:33PM +0200, Matúš Kukan wrote:
Sure, will do :-)

>
> I've removed -warnaserror+ . It should not be bad ?

Hm, I think this actually should be bound to
$(ENABLE_WARNINGS_AS_ERRORS), but ulitmately we should build
warning-free, if possible. Of course this can be done later.

>
> What's worse is that I made random symbol exported from
> cli_cppuhelper_native library.
> I tried to build it with dmake and find out what symbols should be
> exported from there but found nothing.

Yes, if you check cli_ure/source/native/msvc.map , you will note that it
does not define any global symbol.

> So that library is proly useless ? Anyway, who cares, it's windows..
> but with rules in gbuild in such cases you are missing .lib file and get error.
> I've found out this some time ago when I was converting some windows module.
> So, the exported symbol is workaround for this.

Hm, does the linker need at least one exported symbol to create the .lib
file? I need to check how is this done in dmake...

Many thanks for your help!

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

On 7 August 2012 08:14, David Tardon <[hidden email]> wrote:
>>
>> I've removed -warnaserror+ . It should not be bad ?
>
> Hm, I think this actually should be bound to
> $(ENABLE_WARNINGS_AS_ERRORS), but ulitmately we should build
> warning-free, if possible. Of course this can be done later.

Well, it was because:
c:\cygwin\home\matus\git\libo\workdir\wntmsci12.pro\CustomTarget\cli_ure\source\basetypes\assembly.cs(22,11):
error CS1699: Warning as Error: Use command line option '/keyfile' or
appropriate project settings instead of
'System.Reflection.AssemblyKeyFile'
error CS1606: Assembly signing failed; output may not be signed -- The
system cannot find the file specified.
make: *** [C:/cygwin/home/matus/git/libo/workdir/wntmsci12.pro/CliLibraryTarget/cli_basetypes.dll]
Error 1

So, maybe it will work with -keyfile parameter.

> Yes, if you check cli_ure/source/native/msvc.map , you will note that it
> does not define any global symbol.

How is it used then ?
Clearly my knowledge about libraries is poor.

>> So that library is proly useless ? Anyway, who cares, it's windows..
>> but with rules in gbuild in such cases you are missing .lib file and get error.
>> I've found out this some time ago when I was converting some windows module.
>> So, the exported symbol is workaround for this.
>
> Hm, does the linker need at least one exported symbol to create the .lib
> file? I need to check how is this done in dmake...

With dmake every library exports GetVersionInfo()
Somewhere it creates the .c file and adds it to library.

Best,
Matus
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

On Tue, Aug 07, 2012 at 09:43:50AM +0200, Matúš Kukan wrote:
Right. So it is better to use -keyfile:file here. I will change it.

> error CS1606: Assembly signing failed; output may not be signed -- The
> system cannot find the file specified.
> make: *** [C:/cygwin/home/matus/git/libo/workdir/wntmsci12.pro/CliLibraryTarget/cli_basetypes.dll]

I think this is because $(OUTDIR)/bin/cliure.snk file is not present or
the path is wrong--this error message is before your path format changes
in CustomTarget_cli_ure_assemblies.mk, is it not?

> > Yes, if you check cli_ure/source/native/msvc.map , you will note that it
> > does not define any global symbol.
>
> How is it used then ?
> Clearly my knowledge about libraries is poor.

It is not a regular C++ library, but rather a CLI assembly containing
C++ impl. of class uno.util.Bootstrap .

Ah, right, that is it.

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi all,

On Thu, Aug 02, 2012 at 12:00:22PM +0200, David Tardon wrote:
I finally got around to fixing the remaining problems: There were
several more missing dependencies that I found by running make
module.all for all modules in tail_build. In addition to that, I have
run test builds on ppc, ppc64, s390 and s390x (I do not have easy access
to other architectures). I do not suppose I am going to get any more
testers for the branch, so I am going to merge it to master in a couple
of days (most probably on Saturday). Thanks everyone involved
(especially Matus) for testing!

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi David,

Quoting David Tardon <[hidden email]>:

[...]
>
> I do not suppose I am going to get any more
> testers for the branch, so I am going to merge it to master in a couple
> of days (most probably on Saturday). Thanks everyone involved
> (especially Matus) for testing!
>
clean build on mingw (OpenSUSE 12.1) was sucessful:
https://ci.idaia.de/job/LO-Mingw64/88/
https://ci.idaia.de/job/LO-Mingw64/88/console

Ciao
David
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Hi,

On Wed, Sep 19, 2012 at 10:49:46AM +0200, David Tardon wrote:
The branch feature/gbuild_ure has been merged to master.

D.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice

On 22 September 2012 08:22, David Tardon <[hidden email]> wrote:
>
> The branch feature/gbuild_ure has been merged to master.

Sounds great.

I've tried to fix cli_ure build but it seems to be worse than before.
I have no clue and hope that merging feature/vs2012 will help.

Thanks.
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice