Quantcast

vos removal is now merged in master

classic Classic list List threaded Threaded
4 messages Options
Norbert Thiebaud Norbert Thiebaud
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

vos removal is now merged in master

After a heroic review by kendy, the vos-removal branch has been merged
into master and is being pushed as I type :-)

here was no volonteer to do a test build on windows prior to the
merge... so things may go wrong there. (hopefully trivial things like
a missing include, a missing library in a link or some stupid typo)
Joesph Power had a run at the MacOS build and found some issue that
were fixed. they may still be issues, as we didn't have another
iteration to verify...

Linux x86_64 has been build mutiple times... smoketested and manually
tested. the smoketest used to work fine in the branch itself. but the
same smoketest quit working on master before the merge (and still is
not working after the merge)

ToDo list:
- there are some patches in ./patches that still contain some vos:: things.
- there are a bunch of xml file related to uno service description
that still mention vos as a dependencies. this need to be fixed. the
problem is not so much to remove the vos dependencies, but to add the
one that sometimes where introduced to compensate for vos
disappearance. tracking down what the dependencies reallly are did not
seem trivial. a script may be in order to get it right.



Norbert
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Caolán McNamara Caolán McNamara
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: vos removal is now merged in master

On Mon, 2010-10-25 at 21:40 -0500, Norbert Thiebaud wrote:
> Linux x86_64 has been build mutiple times... smoketested and manually
> tested. the smoketest used to work fine in the branch itself. but the
> same smoketest quit working on master before the merge (and still is
> not working after the merge)

FWIW, I pulled this morning and vos-less LibreOffice is passing the
smoketest build for me just fine :-)

C.

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Michael Meeks Michael Meeks
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: vos removal is now merged in master

In reply to this post by Norbert Thiebaud
Hi Norbert,

On Mon, 2010-10-25 at 21:40 -0500, Norbert Thiebaud wrote:
> After a heroic review by kendy, the vos-removal branch has been merged
> into master and is being pushed as I type :-)

        Congratulations ! great work.

> - there are a bunch of xml file related to uno service description
> that still mention vos as a dependencies. this need to be fixed.

        UNO service files are not really used, and are primarily cosmetic
AFAIR, so - I would just remove the vos dependencies, particularly if
that is all in sal now.

        Just wondering what your next target is ;-) we have a number of
interesting things that need doing ;-) an example is a blocker for
release [ we will be feature freezing on Friday ]. For historical
reasons, we have a BrOffice brand in the LANG=pt_BR.UTF-8 locale - and
we adapt our splash for that now. It would be great if we could also
isolate and tweak our %PRODUCTNAME key for these locales too.

        That is fetched variously (no doubt in tangled ways) from things like:
unotools/source/config/configmgr.cxx /PRODUCTNAME/ - and then used in
lots of places - it seems that resource strings have %PRODUCTNAME
auto-magically substituted.

        Sooo ... if configured with --enable-broffice, and in this locale, we
really need to hard-code a switch of product name to BrOffice ;-) - it
takes time, stickability, testing, and is on the critical path for
getting 3.3 (with everyone's improvements) out :-)

        Are you interested ?

        Many thanks,

                Michael.

--
 [hidden email]  <><, Pseudo Engineer, itinerant idiot

_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Andras Timar Andras Timar
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: vos removal is now merged in master

> release [ we will be feature freezing on Friday ]. For historical
> reasons, we have a BrOffice brand in the LANG=pt_BR.UTF-8 locale - and
> we adapt our splash for that now. It would be great if we could also
> isolate and tweak our %PRODUCTNAME key for these locales too.

%PRODUCTNAME is the most common, but we also have %productname%,
$[officename], ${PRODUCT_NAME}, and [ProductName] - all should be
checked.

Andras
_______________________________________________
LibreOffice mailing list
[hidden email]
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Loading...